EWWW and WPPP incompatibility / integration

  • Resolved Bjoern

    (@greencp)


    9 years, 11 months ago

    Hi,

    my plugin WP Performance Pack includes a feature to dynamically create intermediate images on first access. So meta data for intermediate images get created but the files won’t exists then. This causes EWWW IO to delete the intermediate filename ([‘sizes’][‘size’][‘file’]) which breaks the whole thing. I could integrate a workaround (by hooking into wp_update_attachment_metadata and resetting the file names), but I think the better approach would be if EWWW IO wouldn’t delete the file name ( e.g. by adding in commo.php line 1125 an if ( !empty( $optimized_file ) ) ). I guess this check wasn’t necessary yet, as by default those files always exist.

    Apart from that issue, I would like to integrate EWWW Support into WPPP, i.e. use EWWW to optimize dynamically created intermediate Images, if available. I already use WP_Image_Editor class so am I correct that I don’t have to alter much (apart from loading EWWW as I use SHORTINIT for dynamic image serving).

    –
    Björn

    https://wordpress.org/plugins/ewww-image-optimizer/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author nosilver4u

    (@nosilver4u)

    9 years, 11 months ago

    I’ll try and take a look at it today.

    Plugin Author nosilver4u

    (@nosilver4u)

    9 years, 11 months ago

    Ended up with slightly different code (for consistency), but essentially the same as what you suggested. Fix will be in the next release.

    If you’re using WP_Image_Editor, the images will be auto-optimized when you create them, so everything should be good, so long as you aren’t using a temporary filename and renaming the image later (like the WP Retina 2x plugin…).

    Thread Starter Bjoern

    (@greencp)

    9 years, 11 months ago

    Thanks, everything works fine now.

    Integration of EWWW IO into WPPP is also almost finished. Required a bit more work, due to SHORTINIT startup.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘EWWW and WPPP incompatibility / integration’ is closed to new replies.