WordPress.org

Ready to get started?Download WordPress

Forums

Twenty Thirteen
Error in theme code somewhere (JS) (12 posts)

  1. thescarletfire
    Member
    Posted 12 months ago #

    When creating a child theme, something is seriously wrong with the footer.

    JS function arranges footer widgets vertically. Calling this is actually causing my footer in child theme to not float properly.

    It does not allow the four evenly spaced widgets in the child theme's footer. You'll see that when you go to add the fourth widget, it'll go underneath the other three and look way off.

    I've added no custom css or modified the child theme in any way, just a blank child theme of twentythirteen. So something is off in the JS somewhere

    Could someone please take a peek at that? :) I love this new theme, it's by far the best WP default theme ever!

  2. Andrew
    Forum Moderator
    Posted 12 months ago #

    Let's take a peek.

  3. thescarletfire
    Member
    Posted 12 months ago #

    This theme is epic, man. I'm loving it!

  4. Andrew
    Forum Moderator
    Posted 12 months ago #

    Could you provide a link to the the site for safe measure?

  5. thescarletfire
    Member
    Posted 12 months ago #

    Currently, my site is offline and cannot be live at this time. But I've tested it with a new build on localhost, no changes.

    But if you make a child theme off of 2013, and just copy the normal functions and css, and make no changes, then adding 4 widgets from stock WP would reproduce the error.

    I may be able to go live later today if I get other stuff done. :)

  6. Zulfikar Nore
    Member
    Posted 12 months ago #

    That's not a bug, its how the theme is designed.

    If the secondary widget area i.e. the right sidebar is enabled then the footer widgets will align in a column of 3 and with the secondary sidebar off you will get the footer widgets to align in column of 4.

    If that is not what is going on then a live site look is required to determine what the issue is.

  7. thescarletfire
    Member
    Posted 12 months ago #

    Come again, please? You lost me.

    You're saying if I have a sidebar in this default theme (who doesn't?), my footer automatically defaults to a 3-wide footer instead of normal 4? That can't be right. It looks off.

    So, the only way to get a normal, clean, evenly spaced footer with 4 widgets spread out is to never use a sidebar in this theme? Is that what you are saying?

    The parent theme has a sidebar AND footer with 4 widgets, just fine.
    But when you create a child theme, and make no changes, those 4 widgets change alignment with the same sidebar. That can't be correct behavior, it's not consistent.

  8. Zulfikar Nore
    Member
    Posted 12 months ago #

    One of the main intended feature of the theme is the one column content layout hence why the footer widget area is the primary sidebar.

    Its a content first theme :)

  9. thescarletfire
    Member
    Posted 12 months ago #

    Ok, so why would the parent theme display the 4 widgets correctly with a "side" sidebar together? But, when you make a child theme, it suddenly floats all messed up and forces a 3-wide only? :) Try it, you'll see...I'll make you a believer!

  10. thescarletfire
    Member
    Posted 12 months ago #

    Alas, I tried to help. To the theme developers:
    You have made by FAR the best default them ever :) Great work! Thank you x10000!

    If you get a moment and feel like taking a peep at this whole footer/widget thing, perhaps we'll uncover something. I just wanted to do my part and report my findings.

    JS function arranges footer widgets vertically. Calling this is actually causing my footer in child theme to not float properly.

    I'll see if I can find more information that perhaps can help us further. Details to follow later today.

  11. Zulfikar Nore
    Member
    Posted 12 months ago #

    Just double checked - both parent and child theme behave exactly the same i.e 4 footer columns with no sidebar and 3 with sidebar.

    Are you calling the functions.js from the child theme?

    One thing I've notice is that Jetpack kind of messes up the site flow in local servers but is ok on live servers - so I'm guessing there might a slight chance that a plugin is interfering somewhere somehow if you are on a local server.

  12. thescarletfire
    Member
    Posted 12 months ago #

    Thank you for checking :)

    I guess it's something else, ok.

    Now I just have to find a way to make short pages not have the sidebar overlap on the footer...and then I can sleep easy!

    This theme is seriously rockin'.

Reply

You must log in to post.

About this Theme

About this Topic