WordPress.org

Ready to get started?Download WordPress

Forums

Better WordPress Minify
[resolved] Don't work "One minify string will contain" with css (4 posts)

  1. dimagsv
    Member
    Posted 1 year ago #

    Option "One minify string will contain" don't work in bwp minify 1.2.2 with css.
    I think you must fix this in class-bwp-minify.php:
    replace this:

    $this->append_minify_string($this->styles, $queued, $src, $count == $total, true, 'styles');
    // If this style has support for rtl language and the locale is rtl,
    // we will have to append the rtl stylesheet also
    if ('rtl' === $wp_styles->text_direction && isset($the_style->extra['rtl']) && $the_style->extra['rtl'])
    $this->append_minify_string($this->styles, $queued, $this->rtl_css_href($handle), $count == $total, false, 'styles');

    with:

    $this->append_minify_string($this->styles, $queued, $src, $count == $total, false, 'styles');
    // If this style has support for rtl language and the locale is rtl,
    // we will have to append the rtl stylesheet also
    if ('rtl' === $wp_styles->text_direction && isset($the_style->extra['rtl']) && $the_style->extra['rtl'])
    $this->append_minify_string($this->styles, $queued, $this->rtl_css_href($handle), $count == $total, true, 'styles');

    http://wordpress.org/extend/plugins/bwp-minify/

  2. 3dolab
    Member
    Posted 10 months ago #

    To me, it happened to be the opposite: I had to replace the value of the 5th parameter of the first (default) call of the append_minify_string function, at line 849, from true to false.
    The following "rtl" variation doesn't matter to me and should already have been right.

    Apparently, the append_minify_string function at line 684 does check against this parent parameter along with input_maxfiles.

  3. JibsouX
    Member
    Posted 10 months ago #

    hellow apparently you have différent bug for the same option ?

    what happen on the output html code exactly ?
    for u : dimagsv --> don't work = always print 1 string with all the css ?

    end for u 3dolab ?

  4. dimagsv
    Member
    Posted 10 months ago #

    for u : dimagsv --> don't work = always print 1 string with all the css ?

    yes

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.