WordPress.org

Ready to get started?Download WordPress

Forums

LocalCurrency
Doesn't work in content generated by other plugins (4 posts)

  1. notkristina
    Member
    Posted 1 year ago #

    I love the idea that this uses comments instead of shortcodes for futureproofing, and it works fabulously—thank you for creating it! Unfortunately, I have just brought all my plugins up to code to accept shortcodes for currency conversion purposes, and I find that this plugin doesn't render conversions within the content generated by other plugins. Is there any chance for a version that gives the user a choice between shortcode and HTML comment?

    http://wordpress.org/extend/plugins/localcurrency/

  2. notkristina
    Member
    Posted 1 year ago #

    STRIKE THAT. I suddenly remembered seeing a rendering order setting that you had astutely included in the plugin admin, and once I changed that, everything was fine. I am SUPER impressed with this plugin.

    I have two thoughts about it—what would it take to allow the user to select a currency to override the one distilled from their IP address, perhaps by way of a dropdown widget?

    Also, what would it take to add a parameter to the shortcode/HTML comment that would let me override my site's "default" currency as set in the options? I usually post in USD, but occasionally my base currency is the Euro. I'd love to be able to specify Euro or other currencies as I'm inserting the code. Maybe the plugin could recognize the currency code from within the original content? That is, if I use "$10 USD" or "10 KRW," can it identify that currency code and convert accordingly? Perhaps items without a currency code can default back to the site's default currency?

    I may work on something like this myself based on your plugin, because it works so fabulously, but I'd love to talk with you about it if you're still even half interested in working with this plugin. :)

    Thanks again!

  3. notkristina
    Member
    Posted 1 year ago #

    Conversation with myself, scene 3.

    Just tossed this into localcurrency.php at line 170 to kill the whole thing if the "to" and "from" currencies are the same. Seems to work just fine, and keeps redundant conversions out of the picture.

    // If there is no exchange to take place, DO NOTHING.
    if(lcfrom == lcto){
         return false;
    }
  4. Stephen Cronin
    Member
    Plugin Author

    Posted 1 year ago #

    Hi notkristina,

    Actually, I decided to use the comment style shortcodes before the official shortcodes existed. Adding proper shortcodes is on my long list of things to do sometime, but I won't remove the comment style ones because that would break exisitng sites. Anyway, I'm glad that the rendering order setting solved the problem.

    "what would it take to allow the user to select a currency to override the one distilled from their IP address, perhaps by way of a dropdown widget?"

    They should already be able to do that - there should be a drop down list of all the currencies at the bottom of the post. That's needed in case the IP lookup is wrong or if they are an Australian living in China who wants to see it in Australian dollars (as I was when I first wrote the plugin). :)

    Overriding the default currency is a great idea (and one that I think I've heard before). I'm not sure what's involved in do that, but it shouldn't be too hard. I'll have a look into it over the next week.

    "Just tossed this into localcurrency.php at line 170 to kill the whole thing if the "to" and "from" currencies are the same"

    I'm not too sure what this is about. When I look at line 170 of version 2.3, it's in the middle of the function that includes the JavaScript file. The lcfrom and lcto variables don't exist at that point, so I think you must have added that code somewhere else. Which version are you using? That looks like something I should fix.

    I have very little time to spend on my free plugins these days. That said, out of all of my free plugins, this is the one that I think is most useful and which I want to keep going. I'm happy to keep improving it, although I may be a little slow at times. It's probably due for a complete overhaul at some point in the near future to make sure it's using WordPress best practices..

    Cheers,
    Stephen

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic