WordPress.org

Ready to get started?Download WordPress

Forums

WordPress SEO by Yoast
[closed] Does it work correctly with WordPress 3.7 ? (75 posts)

  1. seb.cambrai
    Member
    Posted 5 months ago #

    Hi,
    After upgrading wordpress 3.6.1 -> 3.7 i can read this message in the admin panel : "Warning: Missing argument 3 for wpseo_upgrader_process_complete() in /home/my-directory/wp-content/plugins/wordpress-seo/inc/wpseo-non-ajax-functions.php on line 259".

    Any help please ?
    Thanks.

    http://wordpress.org/plugins/wordpress-seo/

  2. taniav
    Member
    Posted 5 months ago #

    I encounter the very same message after upgrading to 3.7...

  3. leopardman
    Member
    Posted 5 months ago #

    Yes. Me too...

  4. suhayse
    Member
    Posted 5 months ago #

    Me too

  5. photoMaldives
    Member
    Posted 5 months ago #

    I've just updated an unrelated plugin, and seen this error too

    The update process is starting. This process may take a while on some hosts, so please be patient.

    Enabling Maintenance mode…

    Updating Plugin Broken Link Checker (1/1)
    Broken Link Checker updated successfully. Show Details.

    Disabling Maintenance mode…

    Warning: Missing argument 3 for wpseo_upgrader_process_complete() in /home/.../public_html/.../wordpress/wp-content/plugins/wordpress-seo/inc/wpseo-non-ajax-functions.php on line 259

    All updates have been completed.

  6. penmig
    Member
    Posted 5 months ago #

    Same here

  7. creativetopia
    Member
    Posted 5 months ago #

    me too

  8. AvidNetizen
    Member
    Posted 5 months ago #

    Ditto.

  9. laserjobs
    Member
    Posted 5 months ago #

    It would be this function:

    Specifically line 259 is "function wpseo_upgrader_process_complete( $upgrader_object, $context_array, $themes ) {
    $options = get_option( 'wpseo' );"

    /**
     * Check if the current theme was updated and if so, test the updated theme
     * for the meta description tag
     *
     * @since 1.4.14
     *
     * @return  void
     */
    function wpseo_upgrader_process_complete( $upgrader_object, $context_array, $themes ) {
    	$options = get_option( 'wpseo' );
    
    	// Break if admin_notice already in place
    	if ( isset( $options['meta_description_warning'] ) && true === $options['meta_description_warning'] ) {
    		return;
    	}
    	// Break if this is not a theme update, not interested in installs as after_switch_theme would still be called
    	if ( $context_array['type'] !== 'theme' || $context_array['action'] !== 'update' ) {
    		return;
    	}
    
    	$theme = get_stylesheet();
    
    	if ( ( isset( $context_array['bulk'] ) && $context_array['bulk'] === true ) && ( is_array( $themes ) && count( $themes ) > 0 ) ) {
    
    		if ( in_array( $theme, $themes ) ) {
    			wpseo_description_test();
    		}
    	}
    	else if ( $themes === $theme ) {
    		wpseo_description_test();
    	}
    	return;
    }
  10. MdMostfa
    Member
    Posted 5 months ago #

    I can confirm this's happening after the last WP update

  11. ottomek
    Member
    Posted 5 months ago #

    I'm getting this message also when I'm uploading/adding a new plugin. When I disable Yoast and upload a plugin I don't get error message.

  12. laserjobs
    Member
    Posted 5 months ago #

    I am guessing it is checking a theme for the meta description tag and probably does not create any issues but throwing that error code.

  13. dietrichmd
    Member
    Posted 5 months ago #

    same here

  14. thetruejoe90
    Member
    Posted 5 months ago #

    Yep.

    Took out two of my sites. one of them is buggy at the minute and the other is just all over the place.

  15. Russell Jamieson
    Member
    Posted 5 months ago #

    Patching line 259 of /wp-content/plugins/wordpress-seo/inc/wpseo-non-ajax-functions.php as follows stops the error - but the function does nothing so may as well wait for Yoast to fix this if you can live with the warning message.

    function wpseo_upgrader_process_complete( $upgrader_object, $context_array, $themes = array() ) {

    The reason for the failure is that WordPress 3.7 is only passing 2 parameters instead of 3 on a completion of an upgrade in file /wp-admin/includes/class-wp-upgrader.php

    In WordPress 3.6.1 we had do_action( 'upgrader_process_complete', $this, array( 'action' => 'update', 'type' => 'theme' ), $theme ); //3 parameters

    In WordPress 3.7 we have do_action( 'upgrader_process_complete', $this, array( 'action' => 'update', 'type' => 'core' ) ); // only 2 parameters

    I suspect a few other plugins will hit this problem too.

  16. davidmoulton
    Member
    Posted 5 months ago #

    I also have this error.

  17. Akash Ch Gupta
    Member
    Posted 5 months ago #

    Stay calm *Joost de Valk* is on actions.

  18. Rio Grande Citizen
    Member
    Posted 5 months ago #

    I am also having this same issue. I believe Russell Jamieson has found the problem, just need Yoast to make the change.

  19. jamieedwards
    Member
    Posted 5 months ago #

    This is an issue for me too...

  20. M.D.L
    Member
    Posted 5 months ago #

    …Having the same issue…

  21. kimbacaffeinate
    Member
    Posted 5 months ago #

    same error here as well on all updates after upgrading WordPress :)

  22. elevatingyourbusiness
    Member
    Posted 5 months ago #

    me too.

  23. Chris M.
    Member
    Posted 5 months ago #

    I get the same error (noticed it when updating an unrelated plugin, as others have mentioned here).

  24. Chris M.
    Member
    Posted 5 months ago #

    Also, @powerblogservice, you said it doesn't do anything, but why has my XML Sitemap (with Yoast) tanked with a 404 error after upgrading to 3.7?

  25. Rio Grande Citizen
    Member
    Posted 5 months ago #

    From what I understand by reading http://wordpress.org/support/topic/read-this-before-you-post/ -- this plug-in author wants you to register on another website to report problems, rather than discussing them here. So, unless we all follow the instructions in the above link and navigate through a difficult to use developer website, we may never hear from the author concerning this.

  26. Rio Grande Citizen
    Member
    Posted 5 months ago #

    I have reported this as a "bug" (or an "issue) on their Github. For those of you that want to share your sentiments, in hopes that this issue is fixed, please feel free to do so at: http://github.com/Yoast/wordpress-seo/issues/337

  27. elevatingyourbusiness
    Member
    Posted 5 months ago #

    I just ran through the hoops and told SEO about it on its forum
    So join me at:
    https://github.com/Yoast/wordpress-seo/issues/338

  28. rushtipscom
    Member
    Posted 5 months ago #

    @Chris M. That's probably unrelated, it still works on my site (http://rushtips.com/sitemap_index.xml).

    The 404 error has happened to me a few times. You can try to re-install it.

  29. Eddie - Digital Marketing Consultant
    Member
    Posted 5 months ago #

    Will be fixed in the next version. See issue at github.

    It doesn't affect the performance of the plugin. The function is only called when you update plugins/themes/core and it checks whether you updated the current theme and if so, re-checks whether the theme has a <meta description> tag. Nothing major. (via jnfnl)

  30. jrf
    Member
    Posted 5 months ago #

    Everyone, FYI:

    a) This is not a serious issue. It doesn't affect the performance of the plugin nor of WordPress itself. It will not stop any updates from happening either.
    As @laserjobs also said: The relevant function is only called when you update plugins/themes/core and it checks whether you updated the current theme and if so, re-checks whether the theme has a <meta description> tag.
    So nothing really major.

    b) As @Russell Jamieson also said: The issue is caused by a change in WP core in 3.7. They introduced an action hook in 3.6 which WP SEO was using and have changed the way the action is called in 3.7.

    c) The issue was first reported by @vickyindo as a bug straight after the 3.7 release. Within hours, I made a patch available.
    The pull request is waiting for Yoast to review it, but I very much expect it to be included in the next version.
    If you don't want to wait until then, just apply the changes outlined in this commit.

    Oh.. and please do not open any more duplicate bug reports on this issue on GitHub. Duplicates are lazy, not useful and will only be closed.
    Anyway, the issue is solved, a patch is available. You can either apply it yourself or wait for the next version of WP SEO to be released.

    And @Chris M.: that is completely unrelated to this issue - this error has nothing to do with the sitemaps. Please open a separate thread for this and/or if you have more detailed information, file a bug report on GitHub.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic