Datepicker styling conflict with other plugins

slushman
(@slushman)

9 years, 11 months ago

I’m currently developing a plugin that uses the jQuery UI datepicker and the styling from your plugin is conflicting with mine. On my admin page, I’m trying to display the Month and Year dropmenus within the datepicker, but on line 272 of mailchimp.php, you set .ui-datepicker-year to display: none. This affects all instances of the datepicker. Can you please change that line to only affect the datepicker loaded within your plugin?

https://wordpress.org/plugins/mailchimp/

Viewing 7 replies - 1 through 7 (of 7 total)

mc_dominic
(@mc_dominic)

9 years, 11 months ago
Hi Slushman,

Thanks for hopping in the forum. If you’re seeing conflicts with your plugin, a few edits can be made to the MailChimp plugin code to fix the issue. First in the plugin’s js folder modify the datepicker.js file, change line 33 from ui-datepicker-div to ui-mcdatepicker-div. Then in the mailchimp.php file on line 147 and 162 change the jquery that hides and shows the date picker from #ui-datepicker-div to #ui-mcdatepicker-div.

Finally, on the line 272 through 278 replace the css with this:
```
#ui-mcdatepicker-div .ui-datepicker-year {
    display: none;
  }
  #ui-mcdatepicker-div.show .ui-datepicker-year {
    display: inline;
    padding-left: 3px
}
```
That should keep the plugin’s css from interfering with other plugins in your wordpress install. One warning, updates to the MailChimp plugin could overwrite these changes. Let us know if you have any other questions.

-mc_d
Thread Starter slushman
(@slushman)

9 years, 11 months ago

I was able to fix on my site already, but this is a bug within your plugin and it should be fixed on your end, since it causes conflicts with EVERY instance of the datepicker.

I’ve submitted an issue and a pull request on Github for this update:
https://github.com/crowdfavorite/wp-mailchimp/issues/22

mc_gabe
(@mc_gabe)

9 years, 11 months ago

Hey slushman,

Thanks for the feedback and the update on your activity on Github. We appreciate it!

-Gabe

jgwcouk
(@jgwcouk)

9 years, 4 months ago

I have had the same problem with MailChimp conflicting with other plugins. The fix described above works but, as slushman says, it really needs fixing at source. Since this issue is 6 months old I am guessing that hasn’t been yet – what are the chances of it being fixed properly at your end?

Thread Starter slushman
(@slushman)

9 years, 4 months ago

I believe it was rolled in a while back. I put in a pull request on Github a while back and they merged it with their source. I don’t know if its been published with my changes though.

jgwcouk
(@jgwcouk)

9 years, 4 months ago

On the basis that the problem has surfaced on a site I have just built I’m guessing they have not published the change yet. 🙁

mc_kath
(@mc_kath)

9 years, 4 months ago

Hi jgwcouk and slushman,

The CrowdFavorite devs have been working on updating the plugin very recently, so it’s possible this issue was raised with them again. However the original GitHub pull request was closed a while back so I’m not sure what the status is exactly. I’ll be happy to pass along your comments to them to have this looked into again.

Thanks for letting us know this is happening again on your site so we can address it!

-Kath