Custom Image Size Patch 3.6 Update

  • nathangoldstein

    (@nathangoldstein)


    10 years, 8 months ago

    Hi there,

    Recently working with wordpress 3.5, I came across this patch :http://core.trac.wordpress.org/ticket/19889

    …which solved the problem of custom image sizes defined by my theme not resizing or rotating properly. The issue was image-edit.php did not account for sizes added by the function add_image_size (i think this is the name of the function but not 100% sure) in functions.php.

    this patch worked perfectly but unfortunately it does not work on 3.6. image-edit.php seems to have been replaced completely by different files and functions.
    I could backup to 3.5 but the best thing to do is fix it under 3.6! I am not an experienced coder so I wanted to ask someone to have a look at the patch and help me go about fixing the .php file now responsible for editing images.

    Thank you very much and it is somewhat urgent!

    Nathan

Viewing 5 replies - 1 through 5 (of 5 total)
  • Moderator bcworkz

    (@bcworkz)

    10 years, 8 months ago

    The patch doesn’t work because the line numbers are different, but the code to be altered appears to still be the same, so manually editing should work. The global declaration still goes right below the function declaration. The two lines to delete and replace with the if/else structure and $_sizes[ $size ] assignment are on lines 694 & 695.

    Thread Starter nathangoldstein

    (@nathangoldstein)

    10 years, 8 months ago

    @bcworkz, i think I used the patch the same way again just now. But it still doesn’t affect the images on mobile browsers. any ideas?

    Moderator bcworkz

    (@bcworkz)

    10 years, 8 months ago

    SergeyBiryukov just posted a new patch reflecting 3.6 line numbers, see how that works for you.

    Thread Starter nathangoldstein

    (@nathangoldstein)

    10 years, 8 months ago

    Yes I saw, I asked him about it. However, it still doesn’t seem to make changes on browsers from screens less than ~700 px. any ideas as to why? Please see:
    http://www.undergraduateadvantage.ca/textbooks/inventory

    looks fine on desktop

    Thanks bcworkz

    Moderator bcworkz

    (@bcworkz)

    10 years, 8 months ago

    Sorry, no. I have little experience with small screens. I don’t even have a device to check your site with! 🙁

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Custom Image Size Patch 3.6 Update’ is closed to new replies.