WordPress.org

Ready to get started?Download WordPress

Forums

Simplr Registration Form Plus+
Custom Columns Filter (2 posts)

  1. sevenspark
    Member
    Posted 1 year ago #

    Thanks for the plugin, there are a couple of things I thought you'd want to know about:

    1. This filter:

    add_filter('manage_users_custom_column','simplr_column_output',10,3);

    is blocking other plugins from printing custom content. I believe the simplr_column_output function should probably be checking for its own column name and only change the output in that case. Otherwise, you're returning a blank string for all other custom columns.

    2. Minor, but it'd be great to clean up the code producing these notices by checking for the property's existence before trying to access them

    NOTICE: wp-content/plugins/simplr-registration-form/simplr_reg_page.php:212 - Undefined index: page
    NOTICE: wp-content/plugins/simplr-registration-form/simplr_reg_page.php:591 - Undefined index: query
    NOTICE: wp-content/plugins/simplr-registration-form/simplr_reg_page.php:592 - Undefined property: stdClass::$login_redirect
    NOTICE: wp-content/plugins/simplr-registration-form/simplr_reg_page.php:163 - Undefined index: page
    NOTICE: wp-content/plugins/simplr-registration-form/simplr_reg_page.php:252 - Undefined property: stdClass::$mod_on
    NOTICE: wp-content/plugins/simplr-registration-form/simplr_reg_page.php:893 - Undefined index: orderby

    Turn on WP_DEBUG to see the error output.

    Thanks for the plugin!

    Chris

    http://wordpress.org/extend/plugins/simplr-registration-form/

  2. sevenspark
    Member
    Posted 1 year ago #

    (Perhaps something like this check would work well)

    /**
     * Filter custom column output
     * @params $out string (optional) | received output from the wp hook
     * @params $column_name string (required) | unique column name corresponds to the field name
     * @params $user_id INT
     */
    if(!function_exists('simplr_column_output')):
    	function simplr_column_output($out='',$column_name,$user_id) {
    		if( in_array( $column_name , get_option('simplr_reg_fields') ) ){
    			$out = get_user_meta($user_id, $column_name,true);
    		}
    		return $out;
    	}
    endif;

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.