Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Russell Jamieson

    (@powerblogservice)

    Your site is applying the accordion to H4’s

    jQuery('main.content').gcaccordion({"header":"h4"});

    In Genesis Club Lite 1.3, the accordion is by default applied to ‘.entry-content h3’ elements on pages, so this will not affect the JetPack social icons which are wrapped in h4 tags

    So please update to Genesis Club Lite 1.3 to fix this

    The application of the accordion on single pages/posts is on ‘.entry-content h3’ on HTML5 sites like yours; and on XHTML sites it is plain ‘h3’s

    The application of the accordion to archive pages is on ‘article header’ on HTML5 sites and on ‘.post > h2, .post .wrap > h2’ on XHTML sites

    Thread Starter jdaviescoates

    (@jdaviescoates)

    Hi there,

    Your site is applying the accordion to H4’s

    jQuery(‘main.content’).gcaccordion({“header”:”h4″});

    In Genesis Club Lite 1.3, the accordion is by default applied to ‘.entry-content h3’ elements on pages, so this will not affect the JetPack social icons which are wrapped in h4 tags

    So please update to Genesis Club Lite 1.3 to fix this

    Thanks for the info. The JetPack Sharing plugin actually wraps things in h3 tags but I manually changed Genesis Club Lite to use h4 in line 8 of jquery.accordion.js to temporarily get around the problem I was having. Now I’ve just updated both plugins to the latest version and I have the same problem I was having before :-/

    I guess I’ll just have to keep changing Genesis Club Lite to use h4 instead… unless you can think of a better solution?

    Thread Starter jdaviescoates

    (@jdaviescoates)

    This issue is not resolved.

    Plugin Author Russell Jamieson

    (@powerblogservice)

    Hi,

    I had marked this item as resolved as I though the issue was the fact you had changed the code to use h4 tags, and that the upgrade would fix the conflict. However this was not the case. Apologies for jumping the gun.

    Looking at the code on your page, JetPack now uses h3 for the “Share This” title

    <h3 class="sd-title">

    I will add an exclude clause for the accordion so that rather than set up the accordion headings using:

    $(this).find(settings.header).removeClass().addClass('accordion-header');

    it will be

    $(this).find(settings.header).not(settings.exclude).removeClass().addClass('accordion-header');

    The exclude selection will be ‘.sd-title’

    This approach will mean the JetPack/Sharedaddy headings will be ignored by the accordion.

    I will make the code update now and then run some tests.

    Thread Starter jdaviescoates

    (@jdaviescoates)

    OK, great, keep me posted!

    Thanks!

    Plugin Author Russell Jamieson

    (@powerblogservice)

    Please update to Genesis Club Lite 1.3.1.

    Jetpack sharing headings are now explicitly excluded from the accordion

    Thread Starter jdaviescoates

    (@jdaviescoates)

    OK, great!

    I’m not seeing the update in my dashboard yet but I guess I will do so soon… will report back once I do.

    Thanks again! 🙂

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Conflicts with Jetpack Sharing’ is closed to new replies.