Compatibility Problem

Resolved Serafín Danessa
(@sefo262)

10 years, 5 months ago

Hi, I contact you because after installing a WooCommerce add-on, had a problem activating MercadoPago as a gateway with your plugin. Then I investigated, and following This Link I found that is a very simple change that can solve the problem, and improve the plug. There is a possibility to fix that on the next release?
I’ve checked out and the fix seems to be working perfect.

Thanks in advance!

Cheers

http://wordpress.org/plugins/woocommerce-mercadopago/

Viewing 7 replies - 1 through 7 (of 7 total)

Plugin Author Claudio Sanches
(@claudiosanches)

10 years, 5 months ago

Actually I’m not concerned with support for plugins premium.
But how did you fix?

Thread Starter Serafín Danessa
(@sefo262)

10 years, 5 months ago

It seems that it’s also a generic problem that can generate other compatibility issues, but not sure.
This is what it says:

Payment gateway plugins have a property called enabled, which can have one of two values: yes, if gateway is enabled, or no, if the gateway is disabled. The MercadoPago plugin, instead, incorrectly returns a boolean value, i.e. true when it’s enabled and false when it’s disabled.

To fix it you just need to change a line, and that worked for me. But I’m not sure if that affect another part of your plug. Apparently no.

Cheers!

Plugin Author Claudio Sanches
(@claudiosanches)

10 years, 5 months ago

I do not understand.
WooCommerce’s PayPal does that too.
What’s the problem?

Plugin Author Claudio Sanches
(@claudiosanches)

10 years, 5 months ago

Alias returns true or false.
Has no yes or no.

PayPal example: https://github.com/woothemes/woocommerce/blob/master/includes/gateways/paypal/class-wc-gateway-paypal.php#L69

Plugin Author Claudio Sanches
(@claudiosanches)

10 years, 5 months ago

Read here:
https://github.com/woothemes/woocommerce/blob/master/includes/abstracts/abstract-wc-payment-gateway.php#L37-L38

It is bool.

You broke the plugin and forced it always be true!

Plugin Author Claudio Sanches
(@claudiosanches)

10 years, 5 months ago

Fixed in 1.7.0 version.

Thread Starter Serafín Danessa
(@sefo262)

10 years, 5 months ago

Thanks man!
Cheers!

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Compatibility Problem’ is closed to new replies.