WordPress.org

Ready to get started?Download WordPress

Forums

WP-TopBar
[resolved] Close button leaves a blank white topbar (14 posts)

  1. stormymondays
    Member
    Posted 10 months ago #

    Thanks for an excellent plugin!

    I've found a quirk. My topbar slides down after a few seconds (default settings). However, if I close it with the close button, it leaves behind a white empty space, instead of scrolling back up. Can this be fixed in a future version?

    http://wordpress.org/extend/plugins/wp-topbar/

  2. Bob
    Member
    Plugin Author

    Posted 10 months ago #

    That does not happen on my test sites. What is your URL?

  3. Bob
    Member
    Plugin Author

    Posted 10 months ago #

    That does not happen on my test sites. What is your URL?

  4. stormymondays
    Member
    Posted 10 months ago #

    I've enabled on a test site. The site is test.stormymondays .com (splitting the url so it won't get linked). Thanks!

  5. Bob
    Member
    Plugin Author

    Posted 10 months ago #

    Hmmm,, I cannot see the plugin code on that site.

  6. stormymondays
    Member
    Posted 10 months ago #

    Are you sure you are visiting test dot stormymondays dot com? Your default topbar loads on the homepage, with the default text.

    I've emptied the cache just in case.

  7. Bob
    Member
    Plugin Author

    Posted 10 months ago #

    Ok. I see the issue now. I did not use test.. It will take me a couple of days to get some free time to find the issue and resolve it.

  8. stormymondays
    Member
    Posted 10 months ago #

    No problem, I'll keep the site online. Thanks for an excelletnt plugin, and support!

  9. Bob
    Member
    Plugin Author

    Posted 10 months ago #

    OK -- I am back from my business trip.

    I did some testing and was able to duplicate the problem.

    The fix is to add "position:fixed;" to your CSS Option C. That will push your TopBar down, and not overlay the page. So, the CSS would like this:

    position:fixed; top: 40; padding:0; margin:0; width: 100%; z-index: 99999;

    For some reason, when the TopBar does not have "position:fixed", the webpage is not redrawn correctly when the TopBar is closed. It will take me longer to figure out why that CSS is not working correctly.

    Pls confirm this works for you.

    Bob

  10. stormymondays
    Member
    Posted 10 months ago #

    Thanks! I've installed it on the test site. The topbar lays on top of the content without moving it downward when it appears. It's a good workaround until you can find the main CSS problem.

  11. Bob
    Member
    Plugin Author

    Posted 10 months ago #

    Ok, in wp-topbar.php

    Look for this line:

    $html_cookie_out .= ' function close_wptopbar'.($x+1).'() { document.getElementById("topbar'.($x+1).'").style.visibility = "hidden";';

    Change it to:

    $html_cookie_out .= ' function close_wptopbar'.($x+1).'() { jQuery("#wptbheadline'.($x+1).'").toggle();';

    It works on my test site, let me know if it works on your site.

    If so, I'll put it in the next version.

    Bob

  12. stormymondays
    Member
    Posted 10 months ago #

    It works on my test site, thank you!!! :)

  13. Bob
    Member
    Plugin Author

    Posted 10 months ago #

    I just pushed version 5.0 with the fix.. and a few more changes.

  14. stormymondays
    Member
    Posted 10 months ago #

    Thanks! :)

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.