WordPress.org

Ready to get started?Download WordPress

Forums

WP Modal Login
clicking overlay (outside modal window) doesn't close it (5 posts)

  1. Benbodhi
    Member
    Posted 7 months ago #

    Hi Cole,
    Thanks for an awesome plugin!!!

    For some reason when clicking outside the modal window, it won't close... only the actual close button works.

    I tried adding the #overlay id to the close script to no avail.

    I am using wp 3.8, plugin 2.0.6 and running on local using mamp on mac.
    I am not sure if or how a local setup would affect it, but thought I'd mention it anyway.

    Any help would be greatly appreciated.

    Thanks,
    Benbodhi

    http://wordpress.org/plugins/wp-modal-login/

  2. Jtree5757
    Member
    Posted 7 months ago #

    same here

    any ideas on how to fix this?

  3. Jtree5757
    Member
    Posted 7 months ago #

    okay I got it all sorted out. Haven't tested to see if it break any functionality, but it shouldn't.

    Here are the links for the updated js files.
    The first one is wp-modal-login.js
    The second one is wp-modal-login.min.js

    https://drive.google.com/file/d/0B3pr2Ou-d4jTNnZXRGw2SGl1NGs/edit?usp=sharing

    https://drive.google.com/file/d/0B3pr2Ou-d4jTbXFpQ1padkxpZ00/edit?usp=sharing

    Just download them or copy and paste the contents into the original files located in plugins/wp-modal-login/js
    and it should work

  4. Jtree5757
    Member
    Posted 7 months ago #

    If anyone is just interested in the changes:

    Original:

    // Close the modal window and overlay when we click the close button or on the overlay
    	$('.close-btn').click(function() {
    		$('#overlay, .login-popup').fadeOut('300m', function() {
    			$('#overlay').remove();
    		});
    
    		return false;
    	});

    Changed it to:

    // Close the modal window and overlay when we click the close button or on the overlay
    	$(function(){// document.ready shorthand
    	    $(document).on('click','#overlay, .close-btn',function() {
    	        $('#overlay,.login-popup').fadeOut('3000',function(){//use 3000 in place of 300m
    	            $('#overlay').remove();
    	        });
    	        return false;
    	    });
    	});

    P.S. you hav to change min version too to match. I just copied and pasted the entire updated code into this http://dean.edwards.name/packer/ and copied and pasted the output of that tool into the min file.

  5. Benbodhi
    Member
    Posted 6 months ago #

    You legend! Thanks!

    I took it one step further to avoid upgrade issues by placing the following in a plugin file (you could put it straight in a functions file also, changing the $src in wp_register_script to reflect the actual location of your new file, I just tend to keep everything in plugins):

    /**
     * fixes modal login plugin, click outside modal to close
     *
     * deregister modal login script
     * register our own
     */
    function bodhi_deregister_modal_js() {
    
    	wp_deregister_script( 'wpml-script' );
    
    }
    add_action( 'wp_print_scripts', 'bodhi_deregister_modal_js', 100 );
    
    function bodhi_register_new_modal_js() {
    
    	wp_register_script( 'bodhi-wpml-js', plugins_url( '/bodhi-wpml.js', __FILE__ ) . '', '', '', 'true' );
    	wp_enqueue_script( 'bodhi-wpml-js' );
    
    }
    add_action( 'wp_enqueue_scripts', 'bodhi_register_new_modal_js' );

    Then you can duplicate the original plugin js file into your plugin folder and modify it with your changes posted above by Jtree5757.

    Thanks Jtree5757 for your JS goodness ;)

Reply

You must log in to post.

About this Plugin

About this Topic