WordPress.org

Ready to get started?Download WordPress

Forums

Child Themes in 3.1-RC2 (8 posts)

  1. jdblundell
    Member
    Posted 3 years ago #

    I'm running a child theme for P2 version 1.2.1.

    I've just upgraded the site to WordPress 3.1-RC2 and can no longer update the individual template files via the built in editor.

    When I select the parent theme, P2, all my files are available for editing. But when I select the child theme, simplechurchipedia, the only file listed and available for editing is the style sheet.

    Hopefully that's not a "feature" of the new version as that would be a HUGE pain in the rear - especially now that I've adopted child themes for almost all my sites now.

  2. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    This is indeed a feature. But let me explain. :-)

    Basically, when editing a child theme, you were shown the parent theme files as well. This could cause you to accidentally edit the parent theme's files.

    This can be bad, especially if you decide to update the parent theme. Generally speaking, the point of a child theme is so you're not touching the parent theme. So showing both files without any differentiation is silly.

    Hiding the parent theme files and forcing you to go to the parent theme (P2 in this case) to edit those files is specifically the idea. (I wouldn't edit P2 at all, that way you can update it.) Your child theme only has style.css, which is why that's the only file listed. Perhaps we'll add the ability to create files in a future release.

    This was basically just a UX stopgap to curtail an issue. I really hope to review the theme editor soon.

    Further reading:

    http://andrewnacin.com/2010/12/04/incremental-improvements/

    http://core.trac.wordpress.org/ticket/15672

    Hope that helps,
    Nacin

  3. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    And a friend's horror story that inspired me in particular:

    http://www.laurenmichell.com/2010/12/shout-out-of-the-night-nacin/

  4. jdblundell
    Member
    Posted 3 years ago #

    Wow! So that just added even more frustration to my situation -- but also explains what happened to the widget area I had on a not so often used install I'm running with a Twenty-Ten Child theme.

    My understanding of child themes is they're based on hierarchy of files - where WordPress will look for a called file in the child theme directory first and then look in the parent theme if it's not there.

    Not sure why that wouldn't be the case for the Theme Editor on default as well with an exclusion in place for the parent themes.

    I assumed that was always the case since I typically build my child themes by copying the main files (header.php, single.php, sidebar.php, etc. etc.) from the parent theme and making changes that way.

    Now I guess I'll be spending a lot of time today weeding through my child themes and finding out which files I've been editing - the parent or child. :-(

  5. jdblundell
    Member
    Posted 3 years ago #

    Perhaps as a matter of clarification...

    I'm having some issues with a child theme but I'm not sure if it's related to the child theme, 3.1 RC2 or the latest update to the P2 theme.

    http://wordpress.org/support/topic/dropdown-category-selection-for-publishing-posts-in-p2-theme-v121

    When you have a theme, where does it typically pull Java files and additional files for the theme?

    I've essentially copied the entire theme (and related files) into a separate directory and set it up as the child theme. But since I've lost some functionality after a theme upgrade I wonder if I need to make changes to the original theme files instead of in the child theme files.

  6. When you have a theme, where does it typically pull Java files and additional files for the theme?

    From where ever the theme defines them.

    If you're using a child theme, it checks itself first and then the parent.

  7. jdblundell
    Member
    Posted 3 years ago #

    Thanks!

    That's what I assumed but with the issue Andrew brought up, regarding the WordPress Theme editor, I wanted to be sure I was understanding how child-themes work elsewhere.

  8. Nacin was just talking about the theme editor.

Topic Closed

This topic has been closed to new replies.

About this Topic