WordPress.org

Ready to get started?Download WordPress

Forums

Changes Twentyten 1.0 >> 1.1 (35 posts)

  1. cosmicjellybaby
    Member
    Posted 3 years ago #

    Hi there, can anybody offer a quick heads up on the changes between ver 1.0 and ver 1.1?

  2. Chuck Reynolds
    Member
    Posted 3 years ago #

    I 2nd that request. kthxbai

  3. greatdanemaniac
    Member
    Posted 3 years ago #

    Me too!
    So far it seems like only the description of the theme has changed...

  4. Decio
    Member
    Posted 3 years ago #

    I'm also looking for a What's new file.

    Changes found in files:
    attachment.php
    functions.php
    header.php
    loop.php
    style.css

    All of them, very small corrections as far as I can tell.

  5. StevieG
    Member
    Posted 3 years ago #

    It would be nice to see why I should update. Better still would be for the auto update to work! I've tried two different websites now and both have failed saying unable to delete old version of theme and left the site corrupt. Not happy.

  6. Rodrigo M
    Member
    Posted 3 years ago #

    I don't want to lose my mods for just a few small changes,...

  7. Mohammad Jangda
    Member
    Posted 3 years ago #

  8. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    Hey all --

    The only real change is that I removed the half-baked code using the wp_title hook in order to customize the page title, and instead the code was moved back into header.php and simplified a little.

    I can call it half-baked because I was the one who wrote it. It interfered with some plugins and so we yanked it. Twenty Ten is also likely going to be picked apart by up-and-coming theme developers, and I didn't want my inventive technique to gain any traction. (I'd much prefer we introduce a replacement wp_title(), which you'll likely see in a future release.)

    We also made a few minor changes to attachment/media styling and markup. Just some tiny improvements for a few edge cases.

    There's a ton of other small changes in there -- style.css for example -- but they're all stylistic. (Ha! -- get it?) We alphabetized the CSS properties because that's what the theme guys like. :-)

    I see Mo already posted the full diff. If you'd prefer for your head to not explode, here's the log of commit messages: http://core.trac.wordpress.org/log/branches/3.0/wp-content/themes/twentyten/.

    Hope that helps.

    Nacin

  9. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    StevieG: If you can provide more information about the actual error received, the hosting environment, etc., that might make for a good bug report at http://core.trac.wordpress.org/

    PandeBCN: Modifications bad. Upgrades good. To modify a theme like Twenty Ten, it's better to build a child theme! They're awesome, and they're quite resilient to upgrades. Child Themes in the Codex.

  10. Scott Bressler
    Member
    Posted 3 years ago #

    Cool, thanks for letting us know! My head was exploding a bit trying to get past the diff to style.css... :-P

  11. Brandon Moeller
    Member
    Posted 3 years ago #

    Thanks! I really love Twenty Ten, and I found it very easy to automatically upgrade it to 1.1 and to modify it with my own child theme. (just braggin')

  12. Jon Brown
    Member
    Posted 3 years ago #

    I like the new theme update functionality, but it'd be nice if there were a changlog attached/linked to update/upgrade recommendation similar to plug-ins (haven't looked yet if this feature request is already in trac).

  13. cosmicjellybaby
    Member
    Posted 3 years ago #

    Hi, I'm mightily impressed with twentyten - so much so that I've been tweaking it to make it really fit my site. Then don't I go and see that twentyten 1.1 is available and then (for the first time) see that I should have been making those changes to a child theme - son of twentyten if you like. I get the part about the style.css - having a very simple one in the child theme which 'merely' calls on the twentyten style sheet and contains only amendments afterwards. That's all well and good, but I've been merrily making changes to single.php; category.php etc - what happens to these? Do I just have my versions in my son of twentyten directory? Is that it? Is it really that simple?

  14. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    Yep! It really is that easy. It will respect template hierarchy but always check the child theme directory first. The Codex page should explain this well.

  15. MarkRH
    Member
    Posted 3 years ago #

    I changed mine to using the child theme method as well. I actually like doing this better because now I don't have to remember as much what files I've modified. When the theme is updated again, if it is, I can just do a file comparison to see what changes I might need to add into my copy or if it's better to re-add my code into the updated theme's file.

  16. cosmicjellybaby
    Member
    Posted 3 years ago #

    It is that much easier with the child theme method. Just one thing, if I want to change a function, do I just add this to my new functions.php in my child theme folder? So whereas the original functions.php file will have many functions, my functions.php will have only those that I wish to change?

  17. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    @cosmicjellybaby -

    Short answer: Yep!

    Long answer: You can do this for the functions wrapped in function_exists(). (This works because the child theme's functions.php is loaded first.) For those not wrapped in function_exists(), they are attached to a hook. So you can remove the hook (e.g. remove_filter( 'the_hook', 'twentyten_the_function' );), and optionally attach your own function to the same hook.

  18. cosmicjellybaby
    Member
    Posted 3 years ago #

    Hi Andrew - sorry for reopening this thread, but I have made changes to a couple of functions - both twentyten_posted_on() and twentyten_posted_in() and I have cut, pasted and saved them in between <?php... ?> as functions.php in my child theme folder, but I keep getting the 'Headers already sent' warning. It happens especially when I perform an update to a post. I've referred to http://codex.wordpress.org/FAQ_Troubleshooting and done what it suggests there but it keeps cropping up. Any clues?

  19. namklim
    Member
    Posted 3 years ago #

    I've found one change in style.css which I think cannot be overridden in a child theme.

    v1.1 now has the entry below which includes lines for image height and width in style.css which weren't in v1.0. The change can make a mess of images in earlier posts.

    #content img {
    margin: 0;
    height: auto;
    max-width: 640px;
    width: auto;
    }

    see also http://wordpress.org/support/topic/twenty-ten-11-ignoring-image-width-resizing

  20. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    namklim: It was designed to fix an IE8 bug, I believe. I'm having someone look into the side effects.

    cosmicjellybaby: You have whitespace somewhere in your functions.php file. You should have ONE <?php at the top of your file, as the first characters. I would go so far as to omit the closing ?> entirely as it is unnecessary.

  21. brianbatesd
    Member
    Posted 3 years ago #

    Nevermind, had to update the code in header.php in my child theme. Back on track...my site title had disappeared.

  22. cosmicjellybaby
    Member
    Posted 3 years ago #

    Andrew, I have checked - I only have the <?php at the top and I have removed the ?> at the bottom. I still get the 'Headers already sent' message - it refers to line 1 of the functions.php file. Grr...

  23. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    cosmicjellybaby: I thought that you may have had an echo somewhere. But if it's reporting line 1, you probably have a space or some null character before the <?php then. It needs to be the very first characters in the file. I would open a new support thread and others can help you resolve this, if you can't fix it with this.

  24. cosmicjellybaby
    Member
    Posted 3 years ago #

    Andrew: I've done what I shoud have done and re-generated my child_theme/functions.php file, making sure that <?php is the very first piece of text. Things look to be ok now and having checked that all of the template files that I have amended are safely saved and tucked inside the child theme folder, I am going to press the button and update twentyten to ver 1.1... drum roll please...

  25. Chuck Reynolds
    Member
    Posted 3 years ago #

    Cool thanks Nacin

  26. Rodrigo M
    Member
    Posted 3 years ago #

    Thanks: Yes I have to investigate the changes I've made to use the child theme

  27. wordbill
    Member
    Posted 3 years ago #

    Hello --

    Working on my first WP site here. I created a child theme for twenty ten and a corresponding style.css file. Among other things, I used it to style the footer (div#footer div#colophon). This morning after updating to 1.1 (and WP 3.1) I notice that the styling on the footer doesn't work. Looking at the code I see two divs, site-info and site-generator that I don't recognize. Were they added as part of 1.1? I don't have a footer.php in my child theme directory, so I'm assuming the only changes I made initially were to the .css file. Should I now change me css to style these two new divs?

  28. Andrew Nacin
    Lead Developer
    Posted 3 years ago #

    wordbill: footer.php did not change from Twenty Ten 1.0 to 1.1.

  29. aparentdesign
    Member
    Posted 3 years ago #

    Thanks Nacin, that page header thing was annoying me!

  30. Joost Schuur
    Member
    Posted 3 years ago #

    If I could bring the conversation back to the pros and cons of child themes for a second. While it looks like the concept of PHP pages in a child theme directory overriding the parent theme is useful for simpler changes, it becomes less and less so the more PHP pages I need to update over the course of upgrading the original theme, right? Once you start updating things like header/footer/loop etc, your theme isn't going to survive a partial upgrade when the parent theme gets all the new files, but some aren't called up any more because you have child theme files that have precedence.

    To me it feels like I'm stating the obvious here, but I wanted to double check that there's not some other piece of behind the scenes magic that I'm missing.

Topic Closed

This topic has been closed to new replies.

About this Topic

Tags