Bug with … (dot dot dot)

  • Resolved Viktor Nagornyy

    (@viktorix)


    10 years ago

    Seems to be a small bug. It looks like the plugin adds … after full title, not cut off title. Just needs to be moved:

    if (substr($content, $MaxLength, 1) == " ") {
      $content = implode(" ", $aWords).'…';
    } else {
      $content = implode(" ", array_slice($aWords, 0, -1));
    }

    https://wordpress.org/plugins/top-10/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Ajay

    (@ajay)

    10 years ago

    Shouldn’t the … be after both?

    Thread Starter Viktor Nagornyy

    (@viktorix)

    10 years ago

    … indicates that something continues, so it would be best for it to be after truncated title to indicate it was cut and continues. That’s just my opinion.

    It’s called an ellipsis, you can see what it means here
    http://en.wikipedia.org/wiki/Ellipsis

    “series of dots that usually indicates an intentional omission of a word, sentence, or whole section from a text without altering its original meaning”

    That’s why I changed it on our blog.

    Plugin Author Ajay

    (@ajay)

    10 years ago

    Agreed on the meaning. The reason why I say it needs to be on both places is because the portion of the code that you referred to corresponds to the truncated title.

    In the else part of the code, the last element of the array is dropped to remove the half word.

    Thread Starter Viktor Nagornyy

    (@viktorix)

    10 years ago

    When it’s active, having … in the else portion adds it to full title that is within character limit. That’s why I moved it to if. Then it shows after title was cut.

    Plugin Author Ajay

    (@ajay)

    10 years ago

    Understood. I’m going to run a few tests with varying title limits and lengths to try to get a proper solution.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Bug with … (dot dot dot)’ is closed to new replies.