WordPress.org

Ready to get started?Download WordPress

Forums

d3 simplecharts
[resolved] Broken links. d3-simpleCharts -> d3-simplecharts (8 posts)

  1. cheche
    Member
    Posted 1 year ago #

    Please review the url of the plugin.Its inconsistency. So it breaks images

    cheche@casa:/var/tmp/maskk$ wget http://downloads.wordpress.org/plugin/d3-simplecharts.1.2.28.zip
    cheche@casa:/var/tmp/maskk$ unzip d3-simplecharts.1.2.28.zip
    Archive: d3-simplecharts.1.2.28.zip
    d3-simplecharts.1.2.28 packaged: Tue, 11 Jun 2013 06:41:58 +0000
    creating: d3-simplecharts/

    http://wordpress.org/extend/plugins/d3-simplecharts/

  2. Jouni Santara
    Member
    Plugin Author

    Posted 1 year ago #

    Please, what you mean by 'url of plugin' here?

    I noticed that GitHub was missing line.png file.

    I am still trying to figure out how to synch automatically updates from WordPress site to GitHub.

    Now, this is an extra manual step manually after latest updates are always first uploaded into WP's site, unfortunately.

  3. cheche
    Member
    Posted 1 year ago #

    The url of the plugin if you download from wordpress is d3-simplecharts, but your code have d3-simpleCharts

    I have a diff if you want to have a look

  4. cheche
    Member
    Posted 1 year ago #

  5. Jouni Santara
    Member
    Plugin Author

    Posted 1 year ago #

    You are right !!

    The problem was that I was running a hosted own copy on our site that was not before mirrored from uploaded WP package itself.

    Now, all operational URLs are updated on 1.3.3 and this should be not issue. Just let me know if there are any further conflicts of URLs.

    Thank You !!

  6. cheche
    Member
    Posted 1 year ago #

    Hi,
    I did some research, and I made another patch to use plugins_url instead of hard-link.
    https://dl.dropboxusercontent.com/u/31323343/0001-use-plugins_url-http-codex.wordpress.org-Function_Re.patch

    http://codex.wordpress.org/Function_Reference/plugins_url

    Please review and apply if you like it.

  7. Jouni Santara
    Member
    Plugin Author

    Posted 1 year ago #

    Hello,

    Great patch cheche - thank you.

    plugins_url() is the way to go, for sure.

    I put that out public in 1.3.4 since there is one more thing that needs to be added at the morning - as always.

  8. cheche
    Member
    Posted 1 year ago #

    git does not seem updated for this patch

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.