WordPress.org

Ready to get started?Download WordPress

Forums

WP Google Map Plugin
[resolved] Bootstrap stylesheet interfering with Modernize theme (14 posts)

  1. DaveyM
    Member
    Posted 3 months ago #

    I've installed version 2.3.0 of the Plugin and I'm using it with version 2.0 of the Modernize theme - http://themes.goodlayers.com/?theme=modernize

    I found that it broke the front-end, and the admin pages for the theme, due to the inclusion of the following lines in wp-google-map-plugin/css/bootstrap.css

    *,
    *:before,
    *:after {
      -webkit-box-sizing: border-box;
         -moz-box-sizing: border-box;
              box-sizing: border-box;
    }

    I have commented this block out and everything seems ok now. Is it actually required? This appears to be a very general piece of css for a plugin to be providing.

    I assume the bootstrap.css file that is included comes from a custom compilation using LESS to prepend most of the lines with .wpgmp-wrap (or something like that), but combing through it I noticed quite a few other lines without such a prefix and wonder what other problems could be thrown up by it.

    For example:

    Lines 174 - 217

    * {
        color: #000 !important;
        text-shadow: none !important;
        background: transparent !important;
        box-shadow: none !important;
      }
      a,
      a:visited {
        text-decoration: underline;
      }
      a[href]:after {
        content: " (" attr(href) ")";
      }
      abbr[title]:after {
        content: " (" attr(title) ")";
      }
      a[href^="javascript:"]:after,
      a[href^="#"]:after {
        content: "";
      }
      pre,
      blockquote {
        border: 1px solid #999;
        page-break-inside: avoid;
      }
      thead {
        display: table-header-group;
      }
      tr,
      img {
        page-break-inside: avoid;
      }
      img {
        max-width: 100% !important;
      }
      @page  {
        margin: 2cm .5cm;
      }
      p,
      .wpgmp-wrap h2,
      .wpgmp-wrap h3 {
        orphans: 3;
        widows: 3;
      }

    Lines 222 - 224

    select {
        background: #fff !important;
      }

    Lines 230 - 238

    .wpgmp-wrap .table td,
      .table th {
        background-color: #fff !important;
      }
    
    .wpgmp-wrap .btn > .caret,
      .dropup > .btn > .caret {
        border-top-color: #000 !important;
      }

    Lines 248 - 252

    .wpgmp-wrap .table-bordered th,
      .table-bordered td {
        border: 1px solid #ddd !important;
      }
    }

    Lines 513 - 517

    .wpgmp-wrap .dl-horizontal dd:before,
      .dl-horizontal dd:after {
        display: table;
        content: " ";
      }

    and quite a lot more (nearly 50 overall). Is all of this CSS (6000+ lines in the file) actually required for the plugin? That feels like overkill to me, just for displaying a map.

    Thanks,
    David

    https://wordpress.org/plugins/wp-google-map-plugin/

  2. DaveyM
    Member
    Posted 3 months ago #

    Apologies, I see this post is now appearing twice on certain screens (although with the same URL): when I made the first submission I didn't get a confirmation screen but was instead directed to a screen about the forums, so I thought it hadn't worked.

  3. Flipper Code
    Member
    Plugin Author

    Posted 3 months ago #

    Hello DaveyM,

    WE used bootstrap for backend and it's only including for backend interface so any theme you apply on frontend shouldn't be affected with this bootstrap.

    Can you please give me your wp url where i can see this?

    Thanks

  4. Flipper Code
    Member
    Plugin Author

    Posted 3 months ago #

    Any issue for me yet? Please let me know so we can solve your problem asap.

  5. Flipper Code
    Member
    Plugin Author

    Posted 3 months ago #

    Hope you liked our support via skype.

  6. Flipper Code
    Member
    Plugin Author

    Posted 3 months ago #

    Issue Resolved.

  7. DaveyM
    Member
    Posted 3 months ago #

    Apologies for the late reply: I was expecting to receive an automatic email when any follow-ups were made on this thread, but that doesn't appear to have been the case.

    The site is not yet live, but when it is I will post a link to it here. Then you should be able to view source and see that the bootstrap file is included on the frontend.

    On the backend can you please restrict the use of wp-google-map-plugin/css/bootstrap.css to just the pages for administering WP Google Map Plugin, or fix the issues with generic css being included in that sheet?

    Thanks,

    David

  8. Flipper Code
    Member
    Plugin Author

    Posted 3 months ago #

    Hello,

    Well, this is only happening if you're logged as admin in otherwise you don't get this on front end side.

    Thanks

  9. DaveyM
    Member
    Posted 3 months ago #

    I wondered if that was the case when I saw your replies, but no, I have tried it when not logged in and a link to the bootstrap file can still be found in the HTML source.

    It is included immediately after the link to the wp-google-map-plugin/css/google-map.css stylesheet.

    Thanks,

    David

  10. nargarg
    Member
    Posted 3 months ago #

    I had also same problem but i think fixed in new version.

  11. Flipper Code
    Member
    Plugin Author

    Posted 3 months ago #

    Yeah. We fixed up this in today's released version.

  12. DaveyM
    Member
    Posted 3 months ago #

    I have installed the new version and am happy to report that the bootstrap file is no longer included on the frontend or in the admin pages for the Modernize theme.

    Thanks for fixing this,

    David

  13. Flipper Code
    Member
    Plugin Author

    Posted 3 months ago #

    Thanks David. Hopefully it'll help lots of users.

  14. Flipper Code
    Member
    Plugin Author

    Posted 2 months ago #

    Hello,

    Can you please close this topic if issue is resolved for you.

    Thanks

Reply

You must log in to post.

About this Plugin

About this Topic