WordPress.org

Ready to get started?Download WordPress

Forums

WooCommerce Menu Cart
[resolved] Agapebands css link (8 posts)

  1. James
    Member
    Posted 1 year ago #

    Hi Jeremiah (can you update your profile with a name please? Took some digging through old threads to find one, much better than talking to a username don't you think!)

    I've been doing a bit of optimising of my site over the past few days and found a strange link in the header to an unfamiliar site:

    <link rel="stylesheet" type="text/css" href="https://www.agapebands.com/fontawesome/css/font-awesome.css">

    After a bit of investigation, it appears as though it's a style sheet used for the shopping cart icon / menu item of your plugin. Not sure whether this is a forgotten hangover from an early development version, but surely the necessary css needs to be incorporated into the plugin, not called from a (fairly slow!) external site. Also there's a lot of css loading there for one little menu item and logo, so some streamlining looks to be in order :/

    Think this needs an update to correct please!

    Thanks, James

    http://wordpress.org/extend/plugins/woocommerce-menu-bar-cart/

  2. James
    Member
    Posted 1 year ago #

    Woohoo - code paste formatting worked first time :)

  3. James
    Member
    Posted 1 year ago #

    Found the link in wc_cart_nav.php in the following code block:

    
    if ($wccart_icon_display != 1) {
    	function mypage_head() {
        	echo '<link rel="stylesheet" type="text/css" href="https://www.agapebands.com/fontawesome/css/font-awesome.css">'."\n";
    	}
    	add_action('wp_head', 'mypage_head');
    }

    Seems the shopping trolley icon is from the "Font Awesome" font set and this is how the plugin is calling up the relevant file?

    So I've tried saving a copy of the css file (in the plugin directory) and the font files (in a subdirectory of the plugin) and making the respective changes in both the css and php files. Works a treat as a temporary fix and has shaved a whopping second or so off my page load times!

    This definitely needs a rethink, optimisation and update ASAP please!

    Regards, James

  4. Jeremiah
    Member
    Plugin Author

    Posted 1 year ago #

    Hi James, thanks for the heads up! When this plugin was initially released font awesome was not allowed in WordPress because it was not yet GPL compatible. Without going into all the details, what you're seeing is a carry over from that time. I'll get that fixed in the next release. I'm glad you were able to implement a temporary fix.

    Quick unrelated question, were you able to get your I.E. 9 issue figured out using the method I suggested the other day?

  5. James
    Member
    Posted 1 year ago #

    Thanks :)

    Not had chance to play with the IE small formatting issue yet, but it's on my to-do list so will report back success or otherwise in the other thread.

  6. Jeremiah
    Member
    Plugin Author

    Posted 1 year ago #

    Okay, sounds good. If I can swing it I'll try to release an update in the next week.

  7. James
    Member
    Posted 1 year ago #

    Looking forward to update! Thanks Jeremiah :)

  8. Jeremiah
    Member
    Plugin Author

    Posted 1 year ago #

    I'm also marking this one as resolved. The css has been brought into the plugin on the next release instead of being called from a remote site and has been minimized to include only the necessary styles. Will also be coming in the next release.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.