WordPress.org

Ready to get started?Download WordPress

Forums

Link/Obfuscate Telephone Numbers
[resolved] Additional value to custom the telephone number (14 posts)

  1. Xoyozo
    Member
    Posted 10 months ago #

    Hi,

    first of all this is a very useful plugin!

    It would be great if I could use an additional value to custom the telephone number to the user which is not on a smartphone. - Currently the telephone number is displayed in plain text exactly like the value in tel="1234567890". I'd like to format the telephone number like "+12 345 67890" (e.g.) for the non smartphone user with an additional option in the shortcode (like "tel_text", or the like).

    It would be great if you could extend your plugin to the aforementioned manner.

    TIA.

    http://wordpress.org/plugins/tel-link-obfuscate/

  2. grandadevans
    Member
    Plugin Author

    Posted 9 months ago #

    Sorry I have only just seen this. I never seem to get informed that comments have been made.

    Do you still want me to add this to the plugin if I can figure a way to do it?

    John

  3. Xoyozo
    Member
    Posted 9 months ago #

    Hello John,

    that's no problem, thanks for your reply.

    Yes, I would be really happy if you could expand your plugin to that effect.

    TIA!

  4. grandadevans
    Member
    Plugin Author

    Posted 8 months ago #

    Hi,

    I have a few hours to spare so just looking at your request again.

    I'm having a bit of difficulty understanding your request.

    When you day non-smartphone users I assume you mean desktop (or even tablet) users.

    And I assume you want to display the telephone number as "+12 345 67890" just as an obfuscated text and not as a link (obviously there would be no point in making a tel:// link on a desktop).

    If this is the case would you be able to add the text in the format you want in the tel attribute eg. could you enter
    tel="+12 345 67890"
    or will it not let you?

    OR, am I totally misunderstanding your request?

    Thanks :-)
    John

  5. Xoyozo
    Member
    Posted 8 months ago #

    Hello John,

    thanks for spending your spare time to my inquiry.

    When you say non-smartphone users I assume you mean desktop (or even tablet) users.

    Exactly. Of course non-smartphone users shouldn't get present a telephone link.

    And I assume you want to display the telephone number as "+12 345 67890" just as an obfuscated text and not as a link (obviously there would be no point in making a tel:// link on a desktop).

    Correctly.

    If this is the case would you be able to add the text in the format you want in the tel attribute eg. could you enter
    tel="+12 345 67890"

    Yes, but then the OS of the smartphone user uses this format to dial the number directly in the phone app. And this format style isn't the recommended one, because it isn't that much cross phone compatible. The automatic dial format "+1234567890" is the one, which ist most comptabile whith the smartphones and their each OS in recent years.

    Thanks again for your efforts!

  6. Xoyozo
    Member
    Posted 8 months ago #

    Addendum

    I want the link for smartphone dialing like "+123456789" and the visual presented text for the non-smartphone devices like "+12 (0)34 56789".

    If I set tel="+12 (0)34 56789" then dialing by touch isn't possible or successfully. In this case there will be a voice message like "The number you've dialed is not assigned!"

    Cheers.

  7. grandadevans
    Member
    Plugin Author

    Posted 8 months ago #

    Sorry, I get you now. You mean to present a number to smart phone users in line with the features the plugin has already but an additional attribute to apply to the formatting of the telephone number for desktop users.

    Now that I understand that your 1st post makes complete sense. That was my fault for misunderstanding your original request. It's because I haven't looked at it for ages.

    I'll see if I can do this in the next few hours. The hardest bit will probably be getting it updated in the plugin repo.

  8. Xoyozo
    Member
    Posted 8 months ago #

    You mean to present a number to smart phone users in line with the features the plugin has already but an additional attribute to apply to the formatting of the telephone number for desktop users.

    Yes, exactly!

    And there's absolutely no reason for you to apologize here. - I have to apologize that I didn't make my inquiry clear enough to you.

    Once again, It would be great If you could get my input to work and in afterwards in the WP plugin repository.

    TIA!

  9. grandadevans
    Member
    Plugin Author

    Posted 8 months ago #

    Hi,

    Ok, the new feature has been added and is now available in the wordpress repository at
    http://wordpress.org/plugins/tel-link-obfuscate/

    All you have to do to use the feature you requested is add the attribute non_mobile_text.

    So to get the format you wanted just add
    non_mobile_text="+12 345 67890"

    Any problems let me know.
    I won't mark the thread as resolved just yet as I don't know whether you can still comment after it has been marked resolved.

    John

  10. Xoyozo
    Member
    Posted 8 months ago #

    Hello John,

    great, that's exactly the requested feature and it works as expected!

    However, I have the following notes:

    1) After the upgrade from v1.2 to v1.3.2 there are 1 or 2 additonal paragraphs or blank lines after the linked/obfuscated telephone number. - Would it be possible not to have some extra linefeeds (like in the version before)?

    2) The switch of the optional shortcode attribute "debug" has no effect. That means if I add debug="0" the HTML output of "Starting Debugging Script..." between the 'pre'-tags is still being output in the HTML source code. - Would it be possible to fix this also?

    Enjoy your drink.
    Cheers!

  11. grandadevans
    Member
    Plugin Author

    Posted 8 months ago #

    First of all cheers for the drink. Much appreciated.

    Right, the whitespace is being caused by the debug statement which as you pointed out was constantly on. As I only had the shortcode on a page and nothing else I didn't notice it.

    Now the debug option is back to normal (the default is false/0 so you shouldn't even need to add debug="0").

    When you do enable debugging with debug="1" the whitespace is still there but that's an issue for another day for me. Bed time now.

    Again, any problems then just let me know.
    Thanks again,
    John

  12. grandadevans
    Member
    Plugin Author

    Posted 8 months ago #

    Just to let you know there were a few other issues with the plugin that are now resolved and uploaded (v 1.3.7).

    Thanks again for the drink. As an extra bonus you could always give the plugin a rating (I know that rating ratio is low for WordPress plugins so anything I can do to keep on top of them is a bonus)

    Cheers again Sir.
    It was a pleasure dealing with your request and I believe it has helped the plugin grow.

    auf Wiedersehen,
    John

  13. Xoyozo
    Member
    Posted 8 months ago #

    Hello John,

    first of all the requested feature works perfect (the optional attribute "non_mobile_text" works like a charm). So the inquiry of this thread is resolved! - Second, since v1.3.3 there's no whitespace anymore and the HTML/JavaScript-output of the Link/Obfuscate-function is one-line as of now. Great!

    However, in v1.3.7 there a still a few issues:

    1) Namely the default of the debug option is false now (debug="0"), but enabling debugging is not possible (debug="1") since v1.3.3. It seems that debug="0" is now constantly on.

    2) Also setting of the optional attribute noscript_message="Add a custom noscript message" isn't working anymore since v1.3.3. It seems that the default string of "noscript_message" is constantly set to "Please enable JavaScript to see this field".

    3) Last but not least it would be great if you could complete the "Installation"-tab of the WP repository with the section "Attributes Explained" from your website (http://grandadevans.com/resources/wordpress-plugin-to-link-and-obfuscate-telephone-numbers) to have a more completive documentation.

    However, the above bugs are not a problem for me. I just wanted to mention it for the sake of completeness only.

    Yes, I also think that the plugin is even better now.

    Thanks again for your effort.
    Cheers!

  14. grandadevans
    Member
    Plugin Author

    Posted 8 months ago #

    Cheers, the debug and non JS options work for me but one thing I've found out with this plugin is that it can be quite temperamental and what works on one system may not work on another. I have about 5 installations each on a different system configuration that I can test on though. Not sure if you remember but the debug stuff is in the source code (which I'm changing as it's pretty useless if you don't have access to the source code).

    The one thing I now need is time. I think this week may be a push but what I need to do is:

    * Sit down and completely redo the plugin class
    * Add a few more features that I have in mind
    * Rewriting the installation tab
    * Updating my own site's documentation

    Finally, I need to check the installation on each system I have access to in order to minimize the errors (such as the ones that have occurred after this new feature was added).

    Cheers for the head's up about the 2 incomplete features. I will keep an eye on them until I have time to redo the plugin class

Reply

You must log in to post.

About this Plugin

About this Topic