WordPress.org

Ready to get started?Download WordPress

Forums

NextGEN Gallery
A Warning - "ngg_delete_expired_transients" Cronjob (35 posts)

  1. 1aus
    Member
    Posted 10 months ago #

    Sorry to say, I´m angry and that´s not funny anymore and now i´m a little bit fed up.

    The latest update (2.0.23) is flooding my cronjobs, and i have to delete all of them piece by piece by hand. The updated Plugin writing nearly every 1 second a new cronjob, guess what the server did - it died. Imagine nearly 3 hours passed since the update and the surprising discovery, and that´s last but not least not the only domain I have to administrate.

    Only solution, up to now, revert to prior version. And to all the others, look into the logs to verifiy it´s not happening to you. For the unlucky out there the plugin "what´s in cron" will show you all active crons and the plugin "crontrol" will help to delete them.

    Have a good day!

    http://wordpress.org/plugins/nextgen-gallery/

  2. aselektor
    Member
    Posted 10 months ago #

    I am just commented in nextgen-gallery/nggallery.php this code:

    // Delete displayed gallery transients periodically
    		// add_action('ngg_delete_expired_transients', array(&$this, 'delete_expired_transients'));
    		// if (!wp_next_scheduled('ngg_delete_transients')) {
    		//	wp_schedule_event(time(), 'hourly', 'ngg_delete_expired_transients');
    		// }
  3. 1aus
    Member
    Posted 10 months ago #

    Thanks for the quick solution.
    I just discoverd this workaround by myself a few minutes away. Nevertheless you saved my day.

    Greetings!

  4. aselektor
    Member
    Posted 10 months ago #

    Hmmmm! It is very simple! In code have bug! :))) For correct fix it needed just change a code (changes in bold):
    ---------------------
    // Delete displayed gallery transients periodically
    add_action('ngg_delete_expired_transients', array(&$this, 'delete_expired_transients'));
    if (!wp_next_scheduled('ngg_delete_expired_transients')) {
    wp_schedule_event(time(), 'hourly', 'ngg_delete_expired_transients');
    }
    --------------------

    After this created only one cron job.

  5. Vera Schafer
    Member
    Posted 10 months ago #

    You are not alone. Last night my website went down but thanks to the dedication of my hostgator geeks, I found out that this issue has already been addressed and a fix should be available soon. Not a happy camper either.

  6. Vera Schafer
    Member
    Posted 10 months ago #

    Thank you, aselektor! It worked just fine. I disabled the plugin before changing it. Not sure if it matters, but just to be on the safe side. Galleries are now working just fine. Hopefully this bug is fixed on their next update.

  7. aselektor
    Member
    Posted 10 months ago #

    Vera Schafer, thank you!

  8. kalvin07
    Member
    Posted 10 months ago #

    ngg_delete_expired_transients

    This provcess has totally blocked one of the sites i run. For one entire night and half a day!!

    I will definitely quit NGG, a very bad plugin. It used to work before photocrati took over ..

    Like 1Aus above I AM FED UP

  9. aselektor
    Member
    Posted 10 months ago #

    I used the plugin FFF Cron Manager for cleaning WP cron

  10. mkalina
    Member
    Posted 10 months ago #

    Thanks, aselektor, for the crucial notes. However, even when I delete those cronjob-lines with fff cron manager, they keep coming back... :-(

  11. aselektor
    Member
    Posted 10 months ago #

    Mkalina, you need deactivate NGG, before delete all bad cron jobs.
    Change nggallary.php (see above) If you want run NGG again.

  12. mkalina
    Member
    Posted 10 months ago #

    aselektor, I could solve the problem myself:

    1. Deactivate NGG.
    2. Change the hook's name as aselektor put it.
    3. Reactivate NGG.

    What I did - in addition:

    1. I added this line to functions.php. It deletes all photocrati mess rather quickly: wp_clear_scheduled_hook( 'ngg_delete_transients' );
    2. I checked with fff cron manager and all NGG lines were gone.
    3. I reactivated NGG and now I start looking for an alternative. Enough is enough.

  13. gandalfhh
    Member
    Posted 10 months ago #

    @mkalina:
    where did you add the line
    wp_clear_scheduled_hook( 'ngg_delete_transients' );
    in your
    htdocs/wp-includes/functions.php?

    When I add this line at the end, it gives me an error.

  14. mkalina
    Member
    Posted 10 months ago #

    No, gandalfhh, you have to put it in your theme's functions.php (and remove the line, once fff cron manager does no longer show the cronjobs.)

  15. gandalfhh
    Member
    Posted 10 months ago #

    @mkalina
    that worked perfectly. thx.

  16. photocrati
    Member
    Plugin Author

    Posted 10 months ago #

    All - We do apologize for all of this. We are working as fast as possible to develop a patch and get it released as soon as we can.

    Please bear with us while we are preparing this release to address these specific issues with CRON and transients.

    We cannot imagine the frustration this is causing and can only beg for your patience as we work to get this resolved.

    - Cais.

  17. wpnbi
    Member
    Posted 10 months ago #

    Please hurry up with the wp-cron and transients patch.

    I have four servers that won't sop running wp-cron jobs no matter what I do. Have upgraded to newest version of NextGen (2.0.25) but that has not stopped the wp-cron jobs

  18. photocrati
    Member
    Plugin Author

    Posted 10 months ago #

    All - Please update to version 2.0.27 as soon as you are able to. This should resolve the CRON jobs issue that was recently introduced.

    Again, we do apologize for all of these inconveniences and the frustration we have brought to you.

    Just go to your Dashboard and if a notice for the update is not shown then go to the Updates panel, it should be there.

    If you need to download this version specifically for manual installation/updates, here is the direct link: http://downloads.wordpress.org/plugin/nextgen-gallery.2.0.27.zip

    - Cais.
    (cross-posted)

  19. mkilian
    Member
    Posted 10 months ago #

    "All - Please update to version 2.0.27 as soon as you are able to. This should resolve the CRON jobs issue that was recently introduced."

    Whow! It *should*? And did your developers test it as thoroughly as the previous versions since 2.0?

    And what the heck did drive your developers to fuckup the plugin by letting it create an insane number of transients and then "fix" this by introducing a cleaning cron task? This is not a proper way to handle bugs nor to develop software. If some change breaks things backout the change (instead of adding piles of additional changes which try to cleanup the fallout from former changes).

    Aren't you aware that you're throwing shit for about 50 days now at people using ngg (and used to be happy with ngg before the 2.0 disaster)?

    Seriously: may I ask you to resign from maintaining this plugin? Just release a final ngg-2.1 that's identical to 1.9.13 and do your own fancy and new stuff under a new name. Wether something like ngg-2.1 (based on 1.9.13) will be maintained or just bitrot is another question, but *please* keep your hands out of this plugin..

    -- kili

    ps: no, I'm not going to maintain this in any way; instead I'm going to migrate away from it

  20. edanzer
    Member
    Posted 10 months ago #

    Hi Kili - This is Erick from Photocrati. Thanks for your thoughts.

    Just wanted to post a note for you, as well as everyone else in this thread. If you got hit hard by this, you have a right to be angry. Heck, I'm angry and we did it. This was major, and it caught us as well. You have my personal apologies.

    But what's been going on for since the 2.0 launch definitely hasn't been a random process of throwing ---- at people. I published a letter just after the 2.0 launch trying to provide context for what happened and what we were doing:

    http://www.nextgen-gallery.com/open-letter-to-the-nextgen-community-from-erick-danzer/

    I think that still accurately conveys the situation immediately post launch. Since then, we've been in an extremely focused and high intensity push to resolve issues from the 2.0 update. And while there are still some major issues to sort out - especially with respect to use of transients - we've actually made huge progress toward stability. Almost every indicator that we track or that's publicly available, as well as feedback from hundreds (or thousands) of NG users underscores that fact.

    Indeed, one frustrating consequence of this latest episode is that it undermines the sense of progress we've otherwise been making.

    In any case, I don't want to minimize the issue. I know it's major. And you definitely have the right to vent as far as I'm concerned. Just wanted apologize for and affirm the significance of it, while also providing some context.

  21. Franz Josef Kaiser
    Member
    Posted 10 months ago #

    OMG... people!

    Isn't this free software? And isn't it you who updated on a live server without testing in your local install previously? I can't understand how people can get "angry" if they get something for free, expecting it to work 110% perfect in every environment without testing.

    Please, dear users of free software: Look at your workflow, get angry on yourself that you didn't test properly before running an update and then start improving your workflow. Things like that happen all the time. It's a bug, nothing else. And btw: WP_Cron "jobs" clean themselves up after some time. No need to jump in and delete them manually.

  22. wpnbi
    Member
    Posted 10 months ago #

    Hey Franz,

    It's not that simple.

    I have about 170 installations of NextGen on client websites. Those clients often are the ones to click on the "upgrade" button - not me.

    Those clients assume that when an update is available, it has already been tested and is ready for production - just like when their anti-virus software alerts them to an update being available - they install it and move on with their day...

    For a considerably long time, NextGen could be trusted to not break a website. That clearly is no longer the case.

    NextGen updates must now be regarding with suspicion and caution.

  23. kbonner
    Member
    Posted 10 months ago #

    a note for anyone adding the line in your theme's functions - this worked for me but i had to add

    wp_clear_scheduled_hook( 'ngg_delete_expired_transients' );

    not

    wp_clear_scheduled_hook( 'ngg_delete_transients' );

    as mentioned above. Thanks to everyone who made notes here, I had a terrible time with this issue until I found this thread.

  24. mkalina
    Member
    Posted 10 months ago #

    Kristinebonner, this is true, if you have changed the line in nggallery.php as mentioned in this comment.

    And concerning that it finally helped: You're welcome.

  25. Vera Schafer
    Member
    Posted 10 months ago #

    Not sure if I should open a new thread, but since I was affected by that big bug problem for the past two days, and I installed V. 2.0.27, I have to confess that I'm in panic! I have a deadline to finish this site and I have no more excuses to my client.

    So, I purchased the NextGen Pro and created 2 Albums. One was created with the buggy version, which caused my site to go down twice. BUT, the second Album that was created today, doesn't open the galleries. And I just can't figure out why. (yes, I cleared cache, I switched back and forth from Safari to Firefox, etc.).

    The page that works fine is this:
    http://andretelles.com/exemplos/

    And the page that doesn't open the galleries, except # 18, is this:
    http://andretelles.com/exemplos-corp/
    BUT Gallery # 18 has only 18 pictures but when you open it, it shows duplicates that add up to almost 200 images!!!

    Please help me! I don't need to tell you how frustrated I am, considering I used to be a loyal and happy client of NextGen for years!

  26. esmi
    Forum Moderator
    Posted 10 months ago #

    So, I purchased the NextGen Pro

    These forums do not support commercial products. Only the free plugins downloaded from http://wordpress.org/plugins/. Please contact the plugin's vendor directly with any questions about commercial products.

  27. Vera Schafer
    Member
    Posted 10 months ago #

    Thank you

  28. Vera Schafer
    Member
    Posted 10 months ago #

    I see that Erick Danzer from Photocrati posted some comments above regarding the bug that affected both free and paid plugins. So, Erick, could you please be so kind as to let me know where should I repost my problem?
    You can email me at [email redacted - these forums do not provide email support] Thank you!

  29. Franz Josef Kaiser
    Member
    Posted 10 months ago #

    @wpnbi

    It's not that simple.

    I have about 170 installations of NextGen on client websites. Those clients often are the ones to click on the "upgrade" button - not me.

    170 installations? So I guess you donated a lot? Guess not. And if not: don't behave if there's any responsibility by the author of any GPL2+, WTFPL, MIT licensed plugin. And if you still think you can say things like

    updates must now be regarding with suspicion and caution

    then go and read the license. The responsibility has and will be on you. Period.

    Plus: it's your responsibility to not assign your clients roles that allow them to update. Or: craft a plugin that disables plugin update notifications or updates at all - we got the WP HTTP API for that. And as you didn't do that, I can only leave your clients one recommendation: Change your developer. Now.

  30. edanzer
    Member
    Posted 10 months ago #

    @Vera: You can access support for NextGEN Pro by logging in with your details at http://www.nextgen-gallery.com/login. Just click support and submit a ticket there. We'll respond to your ticket via email and take it from there.

Reply »

You must log in to post.

About this Plugin

About this Topic