[Plugin: WP Bannerize] Possible Bug With Filter

  • Resolved SchattenMann

    (@schattenmann)


    12 years, 5 months ago

    i’ve been reading the WP-B code for the past hour trying to figure out why a banner widget wasn’t displayed with no Category Filter or in theIndex page

    i’ve found the *bug* in wpBannerizeFrontend.php line 88

    (is_array( $categoriesID) && !is_category($categoriesID) && !in_category($categoriesID))

    should be replace, in my opinion for:

    (is_array( $categoriesID) && count( $categoriesID) > 0 && !is_category($categoriesID) && !in_category($categoriesID))

    with is_array( $categoriesID) we are checking if $categoriesID is an array but i’ve never checked if the array has childs…$categoriesID will always be an array due to $args = wp_parse_args($theArgs, $default); but if we don’t select categories will be an empty array so this will always return true therefor widget is not display unless categorys are selected…

    i would like to hear from the developers what they think…maybe i’m the one who missunderstood the concept here.

    http://wordpress.org/extend/plugins/wp-bannerize/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author gfazioli

    (@gfazioli)

    12 years, 5 months ago

    @ SchattenMann,
    Ops Yes, you are right!

    I’m going to fix it immediately

    Thank you very much for report

    regards
    GF

    Thread Starter SchattenMann

    (@schattenmann)

    12 years, 5 months ago

    glad i could help mate 🙂

    pi know this is not the correct place but there’s something i would love to see implemented: hierarchical groups like WP Categories

    that would allow me to have the same Banner in different Groups and Call multiple Groups at once with WPB Widget…that would be sooooo sweet!

    Plugin Author gfazioli

    (@gfazioli)

    12 years, 4 months ago

    Thank you again,
    I would like share a little secret (or a preview) with you.
    The next major release of WP Bannerize will allow custom post type with “banner type” hierarchical tree and tag. A banner will be like a post!

    So, stay tuned

    Thanks for all support and suggestions
    GF

    Thread Starter SchattenMann

    (@schattenmann)

    12 years, 4 months ago

    that seems awesome.

    that’s exactly what i thought WPB should evolved …congrats!

    when can we expect that?

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘[Plugin: WP Bannerize] Possible Bug With Filter’ is closed to new replies.