• George

    (@georgegecewicz)


    Bros and ladies, I’ve finally released my own plugin. I’ve tested it on versions of WordPress 2.8 and up and on IE7+ and all the major browsers (Chrome, Safari, Firefox, Opera, etc.). It’s worked consistently for me and I intend it to be a lightweight, easy-to-use plugin for people to get images from their Flickr account without having to get an API key.

    Y’all can check it out here, if you’re so inclined:
    http://wordpress.org/extend/plugins/hey-its-a-flickr-widget/

    Any criticism or advice or “hey, you did this wrong”s are welcome 🙂

    Thanks!

Viewing 1 replies (of 1 total)
  • Sure, i’ll give a little feedback, don’t use flickr though, so not actually testing the plugin(just looking at the code)

    Quick way to examine the code is view the plugin’s main file here(fyi for anyone else who wants to look at code without needing to download).
    http://svn.wp-plugins.org/hey-its-a-flickr-widget/trunk/heyitsflickr.php

    Here’s my critique based on a quick scan over the code.

    1. If you’re going to re-register jQuery, you should make it optional for your users.
    2. You have 3 filters using the same name but passing along different data, perhaps you copied them but forgot to give them unique names?
    3. Make your plugin translation ready, just adding __() and _e() throughout the code isn’t enough, perhaps my blog here will be of use in helping getting your plugin translation ready.
    4. Place any and all text, ie. written text, inside translation functions, so the plugin can be translated completely.

    The blog post i linked to has a very basic example plugin that shows you how to make your plugin translation ready, if you prefer to just learn by looking at code, here’s a direct link to the example plugin.

    Hope that’s helpful.. 🙂

Viewing 1 replies (of 1 total)
  • The topic ‘My First Plugin: Criticism Encouraged’ is closed to new replies.