WordPress.org

Ready to get started?Download WordPress

Forums

External Links
[resolved] 5.0 broke in-post Google Adsense ad completely (11 posts)

  1. archon810
    Member
    Posted 9 months ago #

    After updating to the latest version (by the way, for the love of god, please start using svn tags to tag your releases so us svn users can easily roll back), I found that the in-content AdSense ad is now completely missing. Disabling the plugin fixes it.

    I'm going to revert to the pre-5.0 and leave you this url to play with: http://www.androidpolice.com/2013/10/21/download-latest-google-play-store-4-4-21-with-slide-out-navigation/. Next to the Downloads, you will see a rectangular ad. Any idea why this would happen in 5.0?

    http://wordpress.org/plugins/sem-external-links/

  2. Mike Koepke
    Member
    Plugin Author

    Posted 9 months ago #

    Somebody else just reported this. Let me figure out what the story is.

    Not sure why it is not showing correctly.

    As for the svn tags, I actually have my own svn server running where code is checked into and then it merges the checkin with the wp svn repository. I thought it used to handle tagging correctly. I'll have to look into this as well.

    Mike

  3. archon810
    Member
    Posted 9 months ago #

    Cheers, Mike.

  4. Mike Koepke
    Member
    Plugin Author

    Posted 9 months ago #

    Please try the 5.1 version.

  5. archon810
    Member
    Posted 9 months ago #

    Just upgraded to latest trunk. Looks like it's working.

  6. archon810
    Member
    Posted 9 months ago #

    Errr, something is up with the parsing code. Take a look at this page: http://www.androidpolice.com/2013/11/22/facebook-4-0-test-build-reveals-drastically-revamped-design-apk-download/?cachebust=353464

    You'll see that the first mirror link is not marked as nofollow and doesn't open in a new window.

  7. Mike Koepke
    Member
    Plugin Author

    Posted 9 months ago #

    Looks like the adsense stuff is working.

    the problem link is

    <a href="http://www.androidfilehost.com/?fid=23212708291680607">Android Police mirror #1</a>

    in this case it maybe the local vs. external link detection hiccuping and it thinks it is an internal link. I'm have to check that code. I'm guessing the /?f=.... needs to be handled better.

  8. archon810
    Member
    Posted 9 months ago #

    /? seems like a pretty common use case, don't you think? :-]

    I wonder what else it breaks. Do you have unit tests?

  9. Mike Koepke
    Member
    Plugin Author

    Posted 9 months ago #

    It is a very common case and I shouldn't speculate. It turns out there is an anchor link before that link causing the problem. (You actually have an additional one up on the page that was broken too).

    <a class="toc-anchor" name="download"></a>

    If the code encountered an empty anchor link it would cause the following link or img to not be processed correctly. This bug has been there for a long time. The soon to be released version will correct this bug.

    Mike

    (and yes I have quite an extensive set of test links as 3rd party service keep finding new ways of embedding attributes to add functionality.

  10. archon810
    Member
    Posted 9 months ago #

    The TOC plugin is causing those, but I think they're valid - their only purpose is to place named bookmarks around the page we can jump to.

    I'll keep an eye out for the next version. Thanks.

  11. archon810
    Member
    Posted 8 months ago #

    5.2 fixes this, confirmed.

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.