• Resolved Jay Syder

    (@jay-s)


    After updating to version 2.0.9 I was no longer able to use this plugin. When I try to click the link for google login the page just refreshes and the url becomes huge.

    Bruteprotect has worked with this plugin since I have been using it up until now (approx 6 months) and I really like Bruteprotect. I hope there is a way I can use both plugins. I have currently rolled back to the 2.0.8.1 version and am using that which works fine.

    Link below to plugin I mean if you want to test the issue yourself. I don’t mind waiting a dozen days if someone says that they will look into it. Since the plugin is working fine with this older version.
    http://wordpress.org/plugins/google-apps-login/

    https://wordpress.org/plugins/bruteprotect/

Viewing 10 replies - 1 through 10 (of 10 total)
  • Thread Starter Jay Syder

    (@jay-s)

    I have contacted the author of Google apps login and got more information about the error with a solution if Brute Protect team is interested in implementing to make their plugin friendlier with other login plugins.

    Your version 2.0.9 introduced a conflict with some other login-based plugins (e.g. Google Apps Login) which used to work fine alongside previous versions of your plugin.

    We believe the conflict was due to your change from using the “wp_authenticate” hook to using “authenticate”. The newer hook should either return a WP_User or WP_Error object, but you return neither.

    It seems reasonable to stop execution completely when the IP is blocked (and therefore stop the brute_check_preauth function without returning anything) – although you might want to consider returning a WP_Error object in that case. However, in ‘successful’ cases where the IP is not blocked, please could you return the $user object? This would play better with WordPress’ intentions for the authenticate hook, and hopefully resolve conflicts with other plugins.

    i.e. add “return $user;” as a final line in the brute_check_preauth function of bruteprotect.php.

    +1

    Please fix. Thanks.

    @jay S it seems you are right. Adding a line with

    return $user;

    to the end of function brute_check_preauth() in bruteprotect.php will make Google Apps Login start working again.

    @BruteProtect does this break your protection in any way? If not, could this be added please?

    +1 to this issue and the workaround supplied by @jay S. Would love to see a formal solution offered by the BP folks.

    Plugin Contributor Stephen Quirk

    (@sdquirk)

    Hello, I’m not one of the developers, but I’ve pointed out this thread to those who are. I can’t make any promises, but I’ll at least try to get a better response. Thanks!

    @stephen, thanks! 🙂

    Thread Starter Jay Syder

    (@jay-s)

    Thanks would be great if one of the developers looked into it.

    Plugin Contributor Sam Hotchkiss

    (@samhotchkiss)

    Hi Jay– thanks for your investigation into this– I don’t see any potential issues raised by your fix, so I’ve gone ahead and pushed it up as BP 2.3.3 (with props to you!)

    Please let us know if you have any further issues!

    Best,
    Sam

    Hi Sam,

    Thanks for pushing out this update. WP.org is still showing 2.3.2 as the latest version despite @jay’s fix being implemented in the code because it looks like you forgot to update the version number in bruteprotect.php when committing it to the repository. Can you check that out when you get a moment? Thanks!

    Plugin Contributor Sam Hotchkiss

    (@samhotchkiss)

    Whoops– updated, now with correct version numbers!

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Compatibilty issue with Google Apps Login for WordPress’ is closed to new replies.