• Resolved Brent

    (@colourstone)


    Hi Pippin,

    I have been using this for quite a while now in a multisite, never a problem until today. The view of the map has disappeared but the button is still there and works correctly. I have been checking other plugins for conflicts but I actually haven’t changed anything. Has Google made a change?

    I’d appreciate it if you would take a look please. If you’d look at the bottom of the page here: http://icefinejewelry.com/ you will see what I mean.

    Thank you,
    Brent

    https://wordpress.org/plugins/simple-google-maps-short-code/

Viewing 6 replies - 1 through 6 (of 6 total)
  • Looks like there is a JS error that’s breaking it: http://screencloud.net/v/6awk

    Did you install any new plugins recently? Does it come back if you disable all other plugins?

    Thread Starter Brent

    (@colourstone)

    Hey Pippin, I found the problem, but not quite sure how to fix it.

    The WP Better Minify plugin (bwp-minify) was updated 2 days ago. I turned off all plugins on a test page at: http://icefinejewelry.com/test-post/ except for “plugin organizer” that I use to turn off all other plugins, and your “Simple Google Maps Short Code”. Whenever bwp is active the map won’t show. I went into the plugin settings to ignore minifying it but the only option I had was to ignore “google-maps-api” (http://maps.google.com/maps/api/js?sensor=false) and when I did that I still had the issue. I left the test post so that you could see it.

    Any ideas on how to fix this? The minify plugin really helps with load time and I still need to use it also.

    Thanks again,
    Brent

    The best option I can think of is to get it to ignore the Google maps script somehow. I’m not very familiar with the plugin, but I suspect the author could tell you how to setup the conditional. Could you open a ticket in their forums and see what they say?

    Thread Starter Brent

    (@colourstone)

    Hey Pippin, we got things fixed.

    I talked with Khang Minh who wrote the Better WordPress Minify plugin. Here is his response to my email:

    Hi Brent,

    I’ve added the work around and it seems to work. I’ve added this comment: “// workaround for BWP Minify plugin – added by Khang Minh” to where I edited in that plugin’s file (there’s only one PHP file).

    I will try to provide an update at the end of this week, or you can contact Pippin about this work around, it will make his plugin more compatible with other minify plugins as well.

    Hope that helps 🙂

    Here is what he added to you plugin to fix the issue:

    // workaround for BWP Minify plugin - added by Khang Minh
    jQuery(document).ready(function(){
    			pw_run_map_<?php echo $map_id ; ?>();
    });
    		</script>
    		<a href="http://maps.google.com/maps?q=<?php echo esc_attr( $address ); ?>" target="_blank"><input type="button" class="pw_button" value="Get Directions"></a>
    		<?php
    	endif;
    	return ob_get_clean();
    }
    add_shortcode( 'pw_map', 'pw_map_shortcode' );

    Hope this is beneficial for all.
    Brent

    Glad to hear it!

    Brent,

    I experienced the same thing you were and found this thread while I was looking for a solution.

    The BWP Minify plugin now has a “compatibility mode” checkbox that fixes this issue. They even reference Pippin’s Simple Google Maps Short Code plugin as an example. I’m sure that is because you brought it to their attention.

    Thank you for raising the issue with BWP Minify.

    Scot

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Map view just quit? Button still works…?’ is closed to new replies.