• Siddiq

    (@hasbunallahdotcom)


    Hi Ashley
    Superb plugin and have been using it for more than a year now and my visitors love it.
    Just today i experienced an issue when adding a file to the download, it was published successfully but when i include it with [ddownload id=” “] shortcode, the file does not get downloaded.
    To identify whether it’s only this and its impacting all, I just found out that its impacting all downloads using this plugin. May be a bug. Please look into it and possibly release a patch at earliest.

    Thanks much and keep up the good work !!

    Regards
    Muhammad

    https://wordpress.org/plugins/delightful-downloads/

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author A5hleyRich

    (@a5hleyrich)

    Hi there,

    What is happening with the downloads? Are they downloading but corrupt/empty or are you receving an error message?

    Could you also please supply your support information. If you don’t want to post it here you can email it to me at hello[at]delightfulwp.com.

    One more thing, do you have a custom upload location setup?

    Thanks,

    Ashley

    Thread Starter Siddiq

    (@hasbunallahdotcom)

    Hi Ashley
    Sent you two emails, no response as yet, not sure if you’re getting my emails so posting my last message to you here.

    While i was waiting for you to get back to me on this issue of downloads not working, i tested this plugin on my test website which has same contents of my production site, but it’s running Delightful downloads version 1.3.7 (one less than the current version 1.3.8). And to my surprise, all downloads are working fine with no issues. I am using all the same plugins on my test site so there should not be any plugin incompatibility issue.

    The only difference i found by comparing the support information of the two sites, is the upload directory. In production (which is not working is root / while in the test site there is a directory defined upload_browse_dir: /wp-content/uploads/books/

    This proves that the current plugin 1.3.8 has caused this issue. I wish i can go back to 1.3.7 while a fix is found. Kindly look into the issue and provide a fix at earliest.

    Plugin Author A5hleyRich

    (@a5hleyrich)

    Do you also get the same issue on your test site with the latest version of Delightful Downloads? Please test this and let me know. As for your live site, there is nothing stopping you from using the previous version, which can be downloaded here.

    Ashley

    Plugin Author A5hleyRich

    (@a5hleyrich)

    Either way, I don’t think the issue is caused by the file location and is more likely to be because of output buffering. Can you try changing the following lines in includes/process-download.php (line 93)

    do {
    	@ob_end_clean();
    } while ( ob_get_level() > 0 );

    to

    //do {
    	//@ob_end_clean();
    //} while ( ob_get_level() > 0 );

    Ashley

    Thread Starter Siddiq

    (@hasbunallahdotcom)

    Yes version 1.3.8 is causing issue on my test site even.
    Just verified this by upgrading my test site to 1.3.8 and now all downloads have stopped.

    Thread Starter Siddiq

    (@hasbunallahdotcom)

    Yes this disablement has fixed the issue. Both sites now working fine.
    Have observed that this code is not present in the version 1.3.7 process-download.php, seems it was an introduction of output buffering. was it?

    Thread Starter Siddiq

    (@hasbunallahdotcom)

    One thing also i have noticed, that a new download link created thrice by myself and it says for the first two “undefined” id and then the third one allowed it however it says no file exists. Weird issue, i am going back to 1.3.7. testing it now.

    Plugin Author A5hleyRich

    (@a5hleyrich)

    I’m not sure why your server doesn’t like the updated way of clearing the output buffers. It’s a nightmare to test because I can’t replicate the issue and dealing with output buffering is like voodoo magic at the best of times.

    If your test site is online and you don’t mind me taking a look that would be appreciated.

    Ashley

    Thread Starter Siddiq

    (@hasbunallahdotcom)

    I can provide you ftp access. is that ok?

    Plugin Author A5hleyRich

    (@a5hleyrich)

    That would be awesome thank you.

    Ashley

    Thread Starter Siddiq

    (@hasbunallahdotcom)

    will be sending you via email shortly.

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘Downloads not working’ is closed to new replies.