WordPress.org

1. Stephr0x0rs
   Member
   Posted 1 year ago #

   I'm not sure what happened, but now when I click on a thumbnail from my gallery, the "full size" link seems to be missing. In fact, the whole text area looks different. I haven't touched anything for the nextgen gallery, although I was messing with a few other plugins but I don't know how that could be affecting it.

   It's almost as if it's using a different js or something. Also, it doesn't seem to be showing the image description like it should. I have each gallery with its own designated page, and I thought that's what made it display the description, but it seems temperamental. Sometimes it works (if I click on a thumb before the page fully loads), most times it doesn't.

   Here's mine: link

   And the proper: link

   Ideas? x_x

2. alexrabe
   Member
   Posted 1 year ago #

   Which plugins have you activated ?

3. Stephr0x0rs
   Member
   Posted 1 year ago #

   List here: link

   I think the new ones I was messing with were the Ajaxed Wordpress (disabled), comment quicktags (disabled), ajax edit comments (enabled), tinymcecomments (disabled).

4. alexrabe
   Member
   Posted 1 year ago #

   Disable other plugins, one of them integrate the thickbox version of the wordpress admin section and normally this should be not done...

5. Stephr0x0rs
   Member
   Posted 1 year ago #

   Ok, it was the wp-ajax-edit-comments that was apparently causing it.

   Is there any way to make them play nice together? I don't understand how one plugin could be affecting another like that. :\

   Also, it's still not display the image description when clicking on a thumbnail.

6. gregma
   Member
   Posted 1 year ago #

   Now I have the same error... no describtion or "full" link.
   It's the ajax-comment-plugin too...

   Is there a chance for a fix?

7. Flowdrops
   Member
   Posted 1 year ago #

   gregma asked me to have a look at it (altough all mentioned plugins have nothing to do with me). Here's what I found:

   alexrabe did mention it already (thanks, timesaver):

   wp-ajax-edit-comments is including the thickbox CSS from the WP Admin section (version 2.1.0.0, wp-ajax-edit-comments.php, line 1004). Also, lines 964 - 968 are IMHO unnecessary and should be changed/removed by the plugin author.

   I believe a quick fix (untested!) would be to include the ngg-gallery version of the 'thickbox.css' stylesheet just before the head-tag (wp-plugins/nextgen-gallery/thickbox/thickbox.css) but after wp_head().

   If that doesn't help, contact the author of wp-ajax-edit-comments (http://www.raproject.com/ajax-edit-comments-20/).

   HTH

8. gregma
   Member
   Posted 1 year ago #

   lol, thanks for your help flowdrops...
   No idea why I thought that you're the author ;-)

   Well, I tested your idea, didn't work.
   So I hope that somebody else has a good idea!!

   THX

9. ronalfy
   Member
   Posted 1 year ago #

   Hello all.
   I'm the plugin author of Ajax Edit Comments.

   For JS issues, I've ran into a conflict with NGG over their thickbox script. In the latest version, I actually disable the thickbox.js file that's included with NGG since it would load the script twice. A fix would be for the plugin author to use the one supplied with WP 2.5 and up, and use the NGG version for lower versions.

   For CSS issues, I haven't heard about this one before. For 2.113, you can disable the CSS by commenting out line 1006.

   Please let me know if that fixed it. I'll work on a fix from my end in the meantime.

10. gregma
    Member
    Posted 1 year ago #

    Hello,

    unfortunately to comment out the CSS didn't help...

11. ronalfy
    Member
    Posted 1 year ago #

    Okay, here's what's going on. Feel free to contact the NGG author about this, as there's not much I can do about the compatibility issues on my end.

    The author of NGG is loading a custom version of the thickbox.js file and assigning it a unique queue identifier when loading via the WordPress script system. The issue is, I'm also trying to load WordPress 2.5 and 2.6 built-in thickbox script. When that occurs, you get overlapping boxes when launching a NGG image.

    What I tried before was detect when the NGG script is present, and use that one instead of the built-in code. However, it's compacted code, and I can't call the individual functions without running into issues.

    What I've done is detected the NGG script, deregistered it, and used the built-in WP 2.5+ script.

    The problem that you are all experiencing is that the NGG author has modified the thickbox script for his plugin, but my plugin is disabling this custom version.

    The fix would be, that I detect the NGG script, and use it. However, we're now back to the compacted code, which I can't use.

    For those wondering why I need to call a function in the thickbox.js, it's for blogs that have 300+ comments. I'd rather have the thickbox initialize on a per-event basis rather than on the page load (a significant speed increase). So there's really no way I can get away with using a compacted thickbox.js script.

    As of right now, there's no solution except either to a) leave everything as is, or b) deactivate Ajax Edit Comments.

    Thank you all.

12. ronalfy
    Member
    Posted 1 year ago #

    Hello,

    I found a workaround. The author does supply an uncompressed version, so I just copied it over to my plugin and wrote the appropriate support code.

    Please try 2.1.1.5
    http://downloads.wordpress.org/plugin/wp-ajax-edit-comments.2.1.1.5.zip

    If this works for you, please consider a high rating or a donation for the work that went into the compatibility fix.

    PS: If this does work, I will release this as an official version.

13. alexrabe
    Member
    Posted 1 year ago #

    Hi Guys,

    with WP2.5 I renamed the script loader from "thickbox" to "ngg-thickbox" because otherwise I can't load my own "loading icon".
    (I never get response to my ticket in trac http://trac.wordpress.org/ticket/5937)

    Anyway, i will remove thickbox from core in the next major version, because i see the problems with other plugin , like ronalfy descriped above...

    Until that you can switch the effect in gallery -> option to "Custom", but leave the code line to class="thickbox" rel="%GALLERY_NAME%"

    In this case it doesn't add the thickbox script and it can be used from any other plugin or effect loader.

    Hope this will help out...

14. gregma
    Member
    Posted 1 year ago #

    Yesss.... Now everythign works fine! Great :-))

15. ronalfy
    Member
    Posted 1 year ago #

    @Alex,

    You could do what I did with AEC and your loading image issue.

    The variables have global scope, so I just included them at the top of my JavaScript file, added the thickbox.js as a dependency, and overwrote the variables to my image paths.

    In your case, you'll probably want to declare a dummy JS file and overwrite the variables using that. Of course, you'll also want to overwrite mine as well. Not quite sure how to do that unless you include some nice conditional statements that detect AEC.

16. anuragbhateja
    Member
    Posted 11 months ago #

    There is a very small hack for this.

    1. Open any FTP client which you like.
    2. Go to your website’s public_html folder and then proceed to wp-includes >> js >> thickbox.
    3. Open thickbox.js in edit mode.
    4. Search for “TB_PrevHTML + TB_NextHTML” it is in line 129.
    5. Just before this, add from here

    “&nbsp;&nbsp;<a href=’” + url + “‘ id=’TB_FullSize’ title=’Full
    Size’>Full Size&nbsp;&nbsp;” +

    till up here.
    6. Save the file and check the thickbox by clicking an image in gallery of your website.

    Also I have added this in my blog here

Topic Closed

This topic has been closed to new replies.