latest update

Do either of you have any additional information that would assist in figuring out what the issues might have been? Such as:

• What version did you update from?
• What version of WP?
• What theme?
• What stylesheet were you using for the plugin?

I did a test run through of an upgrade with that theme (ElegantThemes Professional) and unfortunately wasn’t able to reproduce anything that comes close to your description. So I’m wondering if something wasn’t fully loaded (which can happen a small percentage of the time when updating via wordpress.org). Today was fairly active in terms of updates, so it is possible that the full package did not load correctly.

If you had your test site up somewhere where I could look at it, that would be helpful. That would give me a more complete idea of the issue.

Regardless of whether that’s possible, it would be helpful to know (1) what stylesheet you were using prior to the update and (2) if that stylesheet remained selected.

Of course, the other possibility is that you weren’t using a stylesheet at all before and were relying on the old table based forms which have been removed from the plugin (this was planned and announced back in the 2.7 version). But even in that case, the update should remain on the stylesheet that was selected (even though it would not have been used).

Well… you get a gold star @summer313!! You found the first actual bug in the new release. (and gold star for me, too… I already have a patch for it.)

In the file forms.php, line 663 is:

if ( ( ! wpmem_test_shortcode( $content, 'wp-members' ) ) ) {

Change it to this:

if ( ( wpmem_test_shortcode( $tos_content, 'wp-members' ) ) ) {

The logic for wpmem_test_shortcode was screwed up (which I’ll explain below) and this resulted in making the link for your TOS the actual TOS content. In your case, your TOS has a lot of HTML markup, and that is what was making things look really big (the <h2> tags).

I went around a few times on how checking shortcodes was going to take place. I wanted to get rid of the wpmem_test_shortcode in favor of the WP function has_shortcode.

However, I have a very supportive user of the plugin who uses WP 3.5 and for a number of reasons, cannot update to 3.6 (or higher). Since has_shortcode is a 3.6 function, I decided to change my original plan and keep the old function.

But I needed some additional functionality for it, so I actually changed the function to utilize some of the WP native shortcode functions’ elements. Obviously, in this location, I screwed up the logic.

This will be patched permanently in 2.9.1, the list for which is already being built. But until then, for any effected users, change that one line as noted and you’ll be fine.