Minor Annoyances

Franklyn Monk
(@maintainer)

10 years, 2 months ago
How do you rate a plugin as multifunctioned as Jetpack?

It nears perfection, but there are plenty of minor annoyances that continually chaff at you. Minor things, little things that feel like shortcuts or placeholders that turn a five minute job into an hour-long search.

One of those burrs that got stuck in my sock was the html code the Sharing module injects for custom services. It inserts inline CSS, setting the background image to the required icon.
```
<span style="background-image:url("http://flattr.com/_img/icons/flattr_logo_16.png");">Flattr</span>
```
Inline CSS. Sigh.

My text-only Sharing buttons were being trailed by a monstrosity—a tiling blob over which you couldn’t read the text. I was shocked, I tell you, Shocked!

And now I have this ugly additional override in my child-theme CSS. Sitting there, all ugly and mean and sloppy.
```
li.share-custom span {
	background-image: none !important;
	}
```
And it’s just stuck there in my sock rubbing at blisters for the rest of my life.

And, also, it seems like I can only make one custom service, which is kinda lame.

Jetpack has multiple features, many of them near perfection, but since I can’t give fractional stars, and near-perfection is not perfection, I have to give a solid four stars.

Use Jetpack, and be prepared to be annoyed.

Viewing 1 replies (of 1 total)

Plugin Contributor Richard Archambault
(@richardmtl)

10 years, 2 months ago
Hi Franklyn!

Thanks for your review!

One of those burrs that got stuck in my sock was the html code the Sharing module injects for custom services. It inserts inline CSS, setting the background image to the required icon.

Yup, that’s currently how we add the custom icons. If you have a workable suggestion as to how to do it better, please let us know! Feel free to open an issue, suggest a fix or even submit a pull request here:

https://github.com/Automattic/Jetpack

If you’d rather not submit the Issue, I’ll gladly do it for you, so just let me know. We just want to encourage as much community involvement as possible; this review was a great start, though!

At the same time though, in my tests using custom sharing services and Text Only as the setting, I did not see any icon show up, and examining the CSS shows me that Jetpack already outputs this css to over-ride the inline CSS:
```
.sd-social-text a.sd-button > span {
background: none !important;
padding-left: 5px;
}
```
We are also using an !important, but we do this automatically, so I don’t know why you’d have to do it manually in your child theme. If you want I could take a closer look at your site to see if I can determine why that is. You can share your URL here, or if you’d rather keep it private, you can contact us via our form at http://jetpack.me/contact-support/

And, also, it seems like I can only make one custom service, which is kinda lame.

I was able to successfully add 2 custom sharing services, and I’ve seen sites with several, so I’m not sure what the issue here would be either. I’ll also gladly look at this once you share your site’s URL.

Jetpack has multiple features, many of them near perfection, but since I can’t give fractional stars, and near-perfection is not perfection, I have to give a solid four stars.

Use Jetpack, and be prepared to be annoyed.

Thank you for the 4 stars! I’d love to be able to convince you to bump it up to 5 stars, though; for those modules that are near perfection, as I mentioned above, please share your issues with us on Github or tell me and I’ll create the issues for them. We want you to be thrilled with Jetpack, not annoyed, so whatever we can do to help let us know!

Viewing 1 replies (of 1 total)

The topic ‘Minor Annoyances’ is closed to new replies.