Support » Plugin: Registration Options for BuddyPress » Deny button doesn't work

Viewing 12 replies - 1 through 12 (of 12 total)
  • Michael Beckwith

    (@tw2113)

    The BenchPresser

    which version of buddypress and our plugin are you using? I can investigate and see if I can recreate the issue with that information.

    Thread Starter Slava Abakumov

    (@slaffik)

    All the latest, 1.8.1 and 4.1.3 respectively

    Michael Beckwith

    (@tw2113)

    The BenchPresser

    I’ll see if i can find anything funny about it and reproduce, this weekend.

    Michael Beckwith

    (@tw2113)

    The BenchPresser

    While I was working on some of banning capabilities, I was able to to mark a pending person as denied and got the email that went along with my test user.

    If not an inconvenience, could you give me the step by step that you used?

    Thread Starter Slava Abakumov

    (@slaffik)

    I have Stop Spammers Registration plugin activated.
    Sometimes spammers go through it, and for this case I use your plugin. They are appearing in a list. I don’t make anything special – just trying to deny using the site for them by checking in a list and clicking Deny button. Then the page is refreshed and nothing changed.

    Michael Beckwith

    (@tw2113)

    The BenchPresser

    I’ll see if adding the Stop Spammers Registration plugin does anything to my local install and if anything clashes. Stand by.

    Michael Beckwith

    (@tw2113)

    The BenchPresser

    Well, I wasn’t able to recreate. However, I also noticed that the Stop Spammers plugin doesn’t play the greatest with our plugin either. BuddyPress Registration Options relies on a user_status being set, which is a field we set upon registration.

    Stop Spammers halts any potential users before we even get to that point and takes over. Admittedly, I don’t know how many one out of every X attempts get through. I did disable Stop Spammers long enough to get a test user through to the BP Register block, and then re-enabled. However, I was able to successfully deny at that time.

    Not quite sure what to say at this point for you. I know our plugin is meant specifically for BuddyPress components and soon re-adding bbPress as that’s closely coupled with BuddyPress. It’s not meant to stop spammers from accessing the site as a whole.

    Thread Starter Slava Abakumov

    (@slaffik)

    Yes, I understand how plugin works, but my main concern was in this: previously these 2 plugins worked well. 99% of spammers were caught by Stop Spammers. And some, that were not identified as spammers, were blocked by your plugin. And deny button worked perfectly. And after some 4.x update of BuddyPress Registration Options this button stopped working for me…

    But anyway, thanks a lot for your willing to help.

    Thread Starter Slava Abakumov

    (@slaffik)

    I have identified the problem.
    Your plugin doesn’t work when translated. I have renamed the /languages/ folder in your plugin – and it started working again.
    It’s easy to fix, hope you will do that soon 🙂

    if ( isset( $_POST['Save'] ) ) {
    ...
    if ( isset( $_POST['Moderate'] ) ) {
    Michael Beckwith

    (@tw2113)

    The BenchPresser

    Could you provide more details for the change that worked for you? The renaming of the languages folder isn’t making sense to me yet, and I would like to make as much sense as I can for this, to see if it’s viable to push out to everyone.

    Thread Starter Slava Abakumov

    (@slaffik)

    I have included above a code, that produces errors.

    You are using English words as keys in $_POST array. When i18n is active, they are in Russian (in my case). So all the code inside that if stopped working as you do if $action == 'Save'.

    Do you now understand the problem? Just never use translatable words as array keys.

    Michael Beckwith

    (@tw2113)

    The BenchPresser

    Not really, given that those keys are never made translatable and there is nothing in the .pot file that is just “Save”. Regardless, I am willing to change those 2 keys a little bit anyway.

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘Deny button doesn't work’ is closed to new replies.