Support » Plugin: Jetpack - WP Security, Backup, Speed, & Growth » Jet Pack erroneously deactivates plugins in other multi-site sites

  • Resolved llocally

    (@llocally)


    When you install JetPack in a subsite of a multi-site it deactivates plugins that are already installed that JetPack also provides. This is correct behaviour in a single site setup.

    In a multi-site (3.6) JetPack deactivates the plugins in ALL sites on the multi-site. So for instance if you have Grunion contact form running in one subsite, activating JetPack in another subsite causes the unrelated subsite to end up with a deactivaed plugin.

    The problem lies in class.jetpack-client-server.php lines 116 & 124 where deactivate_plugins( ) is called with a null second parameter which will de-activate network wide.

    see

    deactivate_plugins ( $plugins, $silent = false, $network_wide = null )
    Parameters:
    (string|array) $plugins Single plugin or list of plugins to deactivate.
    (bool) $silent Prevent calling deactivation hooks. Default is false.
    (mixed) $network_wide Whether to deactivate the plugin for all sites in the network. A value of null (the default) will deactivate plugins for both the site and the network.

    I think this is just a bug that can simply be fixed. Please let me know.

    http://wordpress.org/plugins/jetpack/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Contributor Richard Archambault

    (@richardmtl)

    Thanks very much to the report! I’ll let the Developers know, they’ll try to reproduce and if so, we’ll have it fixed!

    At the same time, it’s worth noting that we aren’t updating grunion anymore, for example, so it may be worthwhile to switch to Jetpack for those sites – but of course, that’s your call and I agree that if what you are say we are doing is what is in fact happening, we should fix that.

    Plugin Contributor Richard Archambault

    (@richardmtl)

    Hi again!

    So I tried to reproduce this:

    1) I installed and activated Grunion in a subsite which did not have Jetpack activated.
    2) I activated Jetpack in another subsite that did not have it activated already (it is already installed in my network) and connected it to WordPress.com (it needs to be connected to deactivate Grunion)
    3) I went back to subsite with Grunion, reloaded Plugins page, and it was still activated.

    So I wasn’t able to reproduce what you described.

    Can you describe YOUR exact steps, please? We’ll figure out what happened.

    Thread Starter llocally

    (@llocally)

    Richard,

    OK I have managed to reproduce what happened in live it in a test environment, I couldn’t make it happen except as follows….

    Step 1. Install grunion and network activate
    Step 2. install jetpack, do not network activate
    Step 3. go to a specific sub site and activate jetpack
    at this point all is well
    step 4. register jetpack with your wordpress.com account, at this point grunion gets deactivated network wide

    I take the point about grunion no longer being developed outside jetpack (although the current code line is the same).

    As an aside, with a multi-site, is iI know you have to activate jetpack individually for each sub-site,but doe sit work using the same wordpress.com account to link to multiple sites? I haven’t got to the point of working out if that creates any issues?

    Plugin Contributor Richard Archambault

    (@richardmtl)

    Great, thank you, I have been able to reproduce those steps as well, the exact same thing happened to me. I’ll pass that on to the developers.

    As for your question, you can link as many sites to the same WordPress.com account as you want, whether or not they are on the same multisite network! I once activated 50+ subsites with the same account and I had no issues.

    Plugin Contributor Richard Archambault

    (@richardmtl)

    Hi! For the record, I chatted with the developers about this a few weeks ago, but then we left for a company meetup. I have just now created a Trac ticket for this usse:

    http://plugins.trac.wordpress.org/ticket/1984#ticket

    Thanks for the report!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Jet Pack erroneously deactivates plugins in other multi-site sites’ is closed to new replies.