• Resolved KeineKaefer

    (@keinekaefer)


    Dear Chad,

    in general excellent work.

    However, if checkboxes are included in the registration form the option “checked by default” doesn’t work.

    Whatever option I chose the checkbox for tos is always checked and my custom newsletter checkbox remains always unchecked. The opposite would be my goal.

    I use WordPress 3.5.1 and WP-Members 2.8.2.

    Best regards

    Kaefer

    http://wordpress.org/extend/plugins/wp-members/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Chad Butler

    (@cbutlerjr)

    There aren’t any known issues in this area (i.e. everything is working), so I’m wondering if there might be a specific configuration that may not have been tested. Do you have a link I could look at?

    If there is an issue, I’d like to be able to the appropriate fix into the 2.8.3 release. You could try out the beta release as well (see: http://rocketgeek.com/release-announcements/wp-members-2-8-3-beta-release-now-available/)

    Thread Starter KeineKaefer

    (@keinekaefer)

    Dear Chad,

    after looking in your code (wp-members-dialog.php, starting line 417) the problem is that you are checking if the form has not yet been submitted with ‘! $_POST’.

    This is quite general. I use the plugin in a template that submits a form before the wpmem register form will be shown.

    Why don’t you check for some wpmem $_POST variables like
    $submitted = ( isset( $_POST[‘a’] ) and ( $_POST[‘a’] === ‘register’ or $_POST[‘a’] === ‘update’ ) ); ?

    Everybody could have this problem if for some reasons a form was submitted before (e.g. another plugin).

    Best regards!

    Thread Starter KeineKaefer

    (@keinekaefer)

    Dear Chad,

    here are two more suggestions:

    1.)
    The painting of the checkboxes is distorted by a line break. At the moment, a checkbox is painted like:

    “Subscribe newsletter?
    checkbox”

    It should be like:
    “checkbox Subscribe newsletter?”

    You might reconsider the line (378 in wp-members-dialog.php) “$form = $form . ‘<div class=”div_’ . $class . ‘”>’;” for checkboxes.

    Why not painting tos and checkboxes in the same way?

    2.)
    On my ‘user-edit’ page the user can change the agreement to the tos.
    I don’t understand the line (360 in wp-members-dialog.php) “if( $wpmem_fields[$row][2] == ‘tos’ && $toggle == ‘edit’ && ( get_user_meta($userdata->ID, ‘tos’, true ) ) )”.

    When should the user have the right to change the agreement to the tos at all? If the user could cancel the agreement, she/he must be suspended immediately.

    Best regards.

    Plugin Author Chad Butler

    (@cbutlerjr)

    Thanks for your suggestions. I’ll take them into consideration.

    With regards to #2:
    That line is not so that the user can edit the TOS. It is so that if a TOS is added later (after you already have users), the TOS will show on the user edit page for any user that has not agreed to the TOS (i.e. they have no TOS value in the db). Any user who has already agreed to the TOS would not see this.

    To give you an idea that I do actually consider user requests/suggestions, that was something that was requested by users.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Registration form – Checked by default doesn't work’ is closed to new replies.