permalinks not updating on save as draft ( EF 0.7.6, WP 3.6 )

  • natebot

    (@natebot)


    10 years, 12 months ago

    WP 3.6-beta1-24113
    EF 0.7.6

    tl;dr: post permalink does not update when saving as draft.

    If I remember this was an older issue and a hack was put in place. However the problem seems to have come back. Maybe as a result of changes in WP 3.6?

    Steps to replicate in a fresh WP Trunk install with EF 0.7.6 ( no modules active except custom statuses ):
    0. Set up permalink structure that uses post name, e.g. /%postname%/
    1. create a new post with title “example title”
    2. Save as draft, the permalink becomes “/example-title/”
    3. Change title to “example title with addition”
    4. Save as draft, the permalink remains “/example-title/” but “/example-title-with-addition/” is expected.

    I have some time to look at this if you point me to the place I should look.

    http://wordpress.org/extend/plugins/edit-flow/

Viewing 7 replies - 1 through 7 (of 7 total)
  • Thread Starter natebot

    (@natebot)

    10 years, 12 months ago

    I think i found it. I need help understanding the logic though.

    In fix_editable_slug() there is a check for “! empty( $post->post_name )” on line 1391 custom-status.php which prevents the slug from being updated ( because in the case above we do have a post_name but the title has changed ).

    I don’t understand the need for this check. When the post is not published it should be malleable, right?

    Thread Starter natebot

    (@natebot)

    10 years, 12 months ago

    Pull request sent.

    lucop1

    (@lucop1)

    10 years, 12 months ago

    I had the same issue and I solved with your solution!!

    When I changed the Status from IDEA to Draft it doesn’t allow me even to edit the post because it didn’t recognize the permalink but now it works.

    Thank you!

    Reinharts

    (@reinharts)

    10 years, 11 months ago

    Same problem for me. Slugs don’t update on draft/title changes.
    Sometimes I even get blank slugs which really messes up Disqus.

    Any solution on this soon?

    Probably related to this:

    http://wordpress.org/support/topic/post-slugs-dissapearing?replies=22

    But .7.6 is what Im running and its still happening.

    Permalinks are /postname/

    Edit: Not running 3.6 as the OP. Just 3.5.1.

    Thanks!

    Thread Starter natebot

    (@natebot)

    10 years, 11 months ago

    My pull request is at:
    https://github.com/Automattic/Edit-Flow/pull/197

    It assumes that the conditional does good work and just needs to be more sensitive to changes in the title. However I don’t see the reason for having the conditional, why not just do the work to update permalink every time. Performance?

    Reinharts

    (@reinharts)

    10 years, 11 months ago

    Tried your fix, nate but when I go to update a post I got a white page of death 🙁

    It DOES actually work, I think.. but updating old posts gives me a white blank page.

    Ugh.. love this plugin but really wish I didn’t have to redo EVERY POST draft that gets a title change.

    Thanks for trying!

    Nick Daugherty

    (@nickdaugherty)

    10 years, 11 months ago

    Pull Request has been merged to master on GitHub.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘permalinks not updating on save as draft ( EF 0.7.6, WP 3.6 )’ is closed to new replies.