ie connect bugfix

Resolved

(@eggproject)

Hello!

I little speak english 🙁
i use this plugin, but do not work ie6,ie7,ie8,ie9,ie10 (this fb bug… 🙁 )

i create bugfix(http://developers.facebook.com/blog/post/2011/07/21/updated-javascript-sdk-and-oauth-2-0-roadmap/):
i replace xfbml button:
FBLOGIN
and Main.php inlucde 234 row:

<?php
      global $jfb_name, $jfb_version, $jfb_js_callbackfunc, $opt_jfb_valid;
      global $opt_jfb_ask_perms, $opt_jfb_ask_stream, $opt_jfbp_requirerealmail;

      $email_perms = get_option($opt_jfb_ask_perms) || get_option($opt_jfbp_requirerealmail);
      $stream_perms = get_option($opt_jfb_ask_stream);
      if( $email_perms && $stream_perms )    $scope = 'email,publish_stream';
      else if( $email_perms )                $scope = 'email';
      else if( $stream_perms )               $scope = 'publish_stream';
      else                                   $scope = '';
      $scope = apply_filters('wpfb_extended_permissions', $scope);
      ?>

    jQuery("#fb-login-button").click(function()
    {
        FB.login(function(response) {
            <?php echo $callbackName; ?>();
        }, {scope: '<?php echo $scope; ?>'});
    });

this work in ie! :DDDD

http://wordpress.org/extend/plugins/wp-fb-autoconnect/

Viewing 3 replies - 1 through 3 (of 3 total)

Plugin Author justin_k
(@justin_k)

11 years ago

As this is a bug in Facebook’s API, I personally wouldn’t recommend hacking the plugin – I’d just wait for them to fix it. While many people find it infuriating how Facebook can’t seem to keep their code working properly, these breaks usually only last from a few hours to a few days, and then things are back to normal.

(The erroneous behavior can even be seen on their own sample page – https://developers.facebook.com/docs/reference/plugins/login – so it’s not limited to this plugin; it seems that they’ve broken xfbml login buttons for IE entirely.)

Thread Starter eggproject
(@eggproject)

11 years ago

Hello!

This not hack!

http://developers.facebook.com/blog/post/2011/07/21/updated-javascript-sdk-and-oauth-2-0-roadmap

describe the link … been a while since you are not always required to facebook Xfbml HTML5 elements or use a lot of operations! it is true that facebook has long been not seem to care about the error but if you look around on the net advised for you everywhere! This bomb definitely work and recommended that no hack facebook! the codes should be modified only minimally … I like to use the plugin so I wrote a patch and the issue is … I could recommend that you put into a relationship is until the admins of Facebook will not fix the problem ….

Plugin Author justin_k
(@justin_k)

11 years ago

“Hack” is a term commonly used to mean modifying someone’s original plugin code – it doesn’t imply that your modification is in any way wrong, etc (I’m sure yours works fine). It’s simply a general recommendation not to modify the plugin code itself (for which there are many reasons: future updates would overwrite it, future changes could be incompatible with it, etc). Of course if you know what you’re doing, you’re welcome to modify whatever you like – but if many users start modifying the plugin, and *they* don’t know why, then it makes my job of supporting them far more cumbersome.

As far as I know, xfbml has not been announced for deprecation. While changing the way it works might ultimately prove necessary, I don’t intend to change it immediately just because there’s a (probably) temporary bug in the API. Facebook does this kind of thing *constantly*, and if I were to rewrite things every time they did, the development of new features would halt accordingly. When I make a change, I don’t simply change it and release it – I test it across all browsers, with and without the premium addon, etc. So it’s not just a matter of throwing your code into the plugin and assuming it works, which is why, at least for a little while, it makes much more sense to just wait for Facebook to clean up their own mess. If even their demo xfbml doesn’t work, I can’t imagine they’d leave it that way for long.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘ie connect bugfix’ is closed to new replies.